From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31927 invoked by alias); 4 Jul 2011 11:26:27 -0000 Received: (qmail 31911 invoked by uid 22791); 4 Jul 2011 11:26:27 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jul 2011 11:26:09 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p64BQ81V022835 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 4 Jul 2011 07:26:08 -0400 Received: from hase.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p64BQ6CP019011; Mon, 4 Jul 2011 07:26:07 -0400 From: Andreas Schwab To: "Andrew Burgess" Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH] Display var_zinteger as signed References: <4E11976B.9030100@broadcom.com> X-Yow: PEGGY FLEMING is stealing BASKET BALLS to feed the babies in VERMONT. Date: Mon, 04 Jul 2011 11:40:00 -0000 In-Reply-To: <4E11976B.9030100@broadcom.com> (Andrew Burgess's message of "Mon, 4 Jul 2011 11:35:23 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00091.txt.bz2 "Andrew Burgess" writes: > @@ -373,8 +372,9 @@ do_setshow_command (char *arg, int from_tty, > struct cmd_list_element *c) > { > fputs_filtered ("unlimited", stb->stream); > } > - else > - fprintf_filtered (stb->stream, "%d", *(int *) c->var); > + /* else fall through */ > + case var_zinteger: > + fprintf_filtered (stb->stream, "%d", *(int *) c->var); > break; The "unlimited" case should not fall through. Andreas. -- Andreas Schwab, schwab@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely different."