From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82427-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19078 invoked by alias); 20 Jul 2011 13:59:35 -0000
Received: (qmail 19067 invoked by uid 22791); 20 Jul 2011 13:59:34 -0000
X-SWARE-Spam-Status: No, hits=-7.5 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 13:59:20 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6KDxJ0P018535	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 20 Jul 2011 09:59:19 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6KDxIf8020057;	Wed, 20 Jul 2011 09:59:19 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6KDxHCl028413;	Wed, 20 Jul 2011 09:59:18 -0400
From: Tom Tromey <tromey@redhat.com>
To: Matt Rice <ratmice@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] bfin: swapped args in bfin_extract_return_value?
References: <CACTLOFpa7MrLx-1UTx08qX2Akdm=Ssb+tHHN0GjdFp+U6r9G-A@mail.gmail.com>
Date: Wed, 20 Jul 2011 14:15:00 -0000
In-Reply-To: <CACTLOFpa7MrLx-1UTx08qX2Akdm=Ssb+tHHN0GjdFp+U6r9G-A@mail.gmail.com>	(Matt Rice's message of "Tue, 19 Jul 2011 19:12:09 -0700")
Message-ID: <m3fwm112a2.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00522.txt.bz2

>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:

Matt> 2011-07-11  Matt Rice  <ratmice@gmail.com>
Matt>         * bfin-tdep.c (bfin_extract_return_value): Fix swapped
Matt>         arguments to store_unsigned_integer.

I think this change is good, but I don't understand why this function
even calls store_unsigned_integer.  I thought
regcache_cooked_read_unsigned did that for you.

Tom