From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83048-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15781 invoked by alias); 15 Aug 2011 19:06:38 -0000
Received: (qmail 15772 invoked by uid 22791); 15 Aug 2011 19:06:37 -0000
X-SWARE-Spam-Status: No, hits=-7.4 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Aug 2011 19:06:17 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7FJ6G0q016601	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 15 Aug 2011 15:06:16 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7FJ6FlM024665;	Mon, 15 Aug 2011 15:06:16 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7FJ6Etw015615;	Mon, 15 Aug 2011 15:06:14 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] printcmd.c (ui_printf): make internalvar string can be printf and eval when inferior cannot alloc memory
References: <CANFwon0RttecHT1BrVx886NC6yCsojHm-MWfr7ttS8=CjoNEzg@mail.gmail.com>	<m339hz1i9v.fsf@fleche.redhat.com>	<CANFwon0wqsOirAz078-y+ti-WFNHGJ45F_-HfS89ViYM02UDFA@mail.gmail.com>
Date: Mon, 15 Aug 2011 19:06:00 -0000
In-Reply-To: <CANFwon0wqsOirAz078-y+ti-WFNHGJ45F_-HfS89ViYM02UDFA@mail.gmail.com>	(Hui Zhu's message of "Sun, 14 Aug 2011 23:09:17 +0800")
Message-ID: <m3fwl2ebq1.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00308.txt.bz2

>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:

>> Thanks for your help.
>> I make a new patch according to your mail.

>> 2011-08-14  Hui Zhu  <teawater@gmail.com>
>>        * printcmd.c (ui_printf): Add a handler for internalvar and
>> TYPE_CODE_ARRAY.

I still don't think this is correct.

This special-cases lval_internalvar, but IIUC this will still fail for
something like:

    printf "hi %s\n", "bob"

In this code I don't think you need to call value_as_address for an
array; likewise reading from memory.

The patch also doesn't address the wide-string case, which it should.

Tom