From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21087 invoked by alias); 2 Nov 2011 17:52:04 -0000 Received: (qmail 21075 invoked by uid 22791); 2 Nov 2011 17:52:01 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Nov 2011 17:51:38 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA2HpbxS018183 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Nov 2011 13:51:37 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pA2Hpa5X001476; Wed, 2 Nov 2011 13:51:37 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA2HpZU1022833; Wed, 2 Nov 2011 13:51:35 -0400 From: Tom Tromey To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: JIT Reader References: <4EA9095D.5070408@playingwithpointers.com> Date: Wed, 02 Nov 2011 17:52:00 -0000 In-Reply-To: <4EA9095D.5070408@playingwithpointers.com> (Sanjoy Das's message of "Thu, 27 Oct 2011 13:03:49 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00043.txt.bz2 >>>>> "Sanjoy" == Sanjoy Das writes: Sanjoy> This work was stalled for some time while the copyright assignment was Sanjoy> being worked on; which will be finalized any time now. Super. Sanjoy> In the meantime, I've attached a rebased set of patches for final Sanjoy> reviews. Thanks, and sorry about the delay. It really is best to ping weekly; the squeaky wheel etc. Sanjoy> +#ifdef HAVE_DLFCN_H Sanjoy> +#include Sanjoy> +#elif __MINGW32__ Sanjoy> +#include Sanjoy> +#else Sanjoy> +/* Unsupported configuration. See Eg. gdb_dlopen for details. */ Sanjoy> +#error API to load shared library missing (Eg. libdl) Sanjoy> +#endif I think this should be a runtime error, not a build-time error, because it seems better to me to make a gdb with reduced functionality than to prevent the build for just this feature. Tom