From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27508 invoked by alias); 11 Jan 2012 21:43:27 -0000 Received: (qmail 27497 invoked by uid 22791); 11 Jan 2012 21:43:25 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Jan 2012 21:43:06 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0BLgxR8028565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 11 Jan 2012 16:42:59 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0BLgxq3024243; Wed, 11 Jan 2012 16:42:59 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q0BLgvn3015528; Wed, 11 Jan 2012 16:42:58 -0500 From: Tom Tromey To: Andreas Tobler Cc: gdb-patches@sourceware.org Subject: Re: [patch] make static_assert gdb private References: <4F0DF81F.3040905@fgznet.ch> <4F0E0205.1090903@fgznet.ch> Date: Wed, 11 Jan 2012 21:46:00 -0000 In-Reply-To: <4F0E0205.1090903@fgznet.ch> (Andreas Tobler's message of "Wed, 11 Jan 2012 22:41:25 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00381.txt.bz2 >>>>> "Andreas" == Andreas Tobler writes: Andreas> Here I have a question about formatting, would the below be better? Yeah, I think so. Thanks again. Andreas> -static_assert (ARRAY_SIZE (async_reason_string_lookup) == Andreas> EXEC_ASYNC_LAST + 1); Andreas> +gdb_static_assert (ARRAY_SIZE (async_reason_string_lookup) Andreas> + == EXEC_ASYNC_LAST + 1); Tom