From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: Performance regression (12x): Re: RFC: add relative file name handling for linespecs
Date: Wed, 01 Feb 2012 15:04:00 -0000 [thread overview]
Message-ID: <m3fweud2a3.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120201102137.GF31383@adacore.com> (Joel Brobecker's message of "Wed, 1 Feb 2012 14:21:38 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> I missed this message! You should have told me and I would have looked
Joel> into it.
Oh, sure, now you tell me ;-)
Joel> Thanks a lot for the patch. I agree that the patch looks correct,
Joel> but I'm a little confused by the name of the new function (the _full
Joel> suffix suggests that the lookup is always a full search).
Joel> Traditionally, we've used a _1 suffix instead, which is very
Joel> unimaginative and yet so convenient. I was going to change
Joel> your patch this way, but in the end, I'm just thinking I should
Joel> just add the parameter and update all callers. There are not that
Joel> many. I suspect you might have thought about this too, only to
Joel> just try the minimum change.
Joel> Would it be OK with you if I made that change instead?
I will do it, it is no big deal.
Tom
next prev parent reply other threads:[~2012-02-01 15:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 16:32 Tom Tromey
2012-01-10 17:40 ` Eli Zaretskii
2012-01-11 21:52 ` Tom Tromey
2012-01-12 6:23 ` Eli Zaretskii
2012-01-16 19:01 ` Tom Tromey
2012-12-08 16:34 ` Jan Kratochvil
2012-12-08 18:33 ` Eli Zaretskii
2013-01-07 15:17 ` [testcase patch] New testcase: DOS drive letters in linespec [Re: RFC: add relative file name handling for linespecs] Jan Kratochvil
2013-01-17 20:42 ` [commit] " Jan Kratochvil
2012-01-11 9:03 ` RFC: add relative file name handling for linespecs Joel Brobecker
2012-01-16 19:29 ` Tom Tromey
2012-01-16 21:07 ` Tom Tromey
2012-01-19 15:39 ` Performance regression (12x): " Jan Kratochvil
2012-01-19 16:35 ` Tom Tromey
2012-01-31 20:18 ` Tom Tromey
2012-02-01 10:22 ` Joel Brobecker
2012-02-01 15:04 ` Tom Tromey [this message]
2012-02-01 15:07 ` Tom Tromey
2012-02-01 15:18 ` Joel Brobecker
2012-02-01 15:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fweud2a3.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox