From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10460 invoked by alias); 15 Apr 2012 20:27:02 -0000 Received: (qmail 10442 invoked by uid 22791); 15 Apr 2012 20:27:01 -0000 X-SWARE-Spam-Status: No, hits=0.0 required=5.0 tests=AWL,BAYES_00,KHOP_DYNAMIC2,RDNS_DYNAMIC X-Spam-Check-By: sourceware.org Received: from 173-13-178-50-sfba.hfc.comcastbusiness.net (HELO sebabeach.org) (173.13.178.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 15 Apr 2012 20:26:49 +0000 Received: by sebabeach.org (Postfix, from userid 500) id E283311F7BD; Sun, 15 Apr 2012 13:26:48 -0700 (PDT) From: Doug Evans To: gdb-patches@sourceware.org Subject: Re: [patch] Create cleanups.[ch] Date: Mon, 16 Apr 2012 02:07:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00397.txt.bz2 I wrote: > Since cleanups are a big enough source of issues, I want to separate them out. > This patch moves the core cleanup API into its own file. > It makes no other changes. > I have at least one more patch to go, but I want to get this done first. > [...] > +/* WARNING: The result of the "make cleanup" routines is not the intuitive > + choice of being a handle on the just-created cleanup. Instead it is an > + opaque handle of the cleanup mechanism and represents all cleanups created > + from that point onwards. > + The result is guaranteed to be non-NULL though. */ Heh, I'm getting ahead of myself. :-) Ignore the last sentence there. The wording of the previous sentence is fine with me, but one may prefer it to say something along the lines of being the handle of the previous cleanup ("old_chain") or something like that, or say nothing at all other than being an opaque handle.