From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4384 invoked by alias); 6 Dec 2013 16:07:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4372 invoked by uid 89); 6 Dec 2013 16:07:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pb0-f47.google.com Received: from Unknown (HELO mail-pb0-f47.google.com) (209.85.160.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 06 Dec 2013 16:07:29 +0000 Received: by mail-pb0-f47.google.com with SMTP id um1so1300829pbc.34 for ; Fri, 06 Dec 2013 08:07:21 -0800 (PST) X-Received: by 10.66.231.6 with SMTP id tc6mr5144660pac.68.1386346041525; Fri, 06 Dec 2013 08:07:21 -0800 (PST) Received: from sspiff.sspiff.org.gmail.com (173-13-178-50-sfba.hfc.comcastbusiness.net. [173.13.178.50]) by mx.google.com with ESMTPSA id g6sm169517931pat.2.2013.12.06.08.07.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Dec 2013 08:07:20 -0800 (PST) From: Doug Evans To: Phil Muldoon Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH 00/13] script language API for GDB References: <52A1C990.1010703@redhat.com> Date: Fri, 06 Dec 2013 16:07:00 -0000 In-Reply-To: <52A1C990.1010703@redhat.com> (Phil Muldoon's message of "Fri, 06 Dec 2013 12:56:48 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00251.txt.bz2 Phil Muldoon writes: > On 06/12/13 05:51, Doug Evans wrote: >> Ok, let's try this again. >> >> On Thu, Dec 5, 2013 at 9:05 AM, Doug Evans wrote: >>> Hi. >>> >>> My patch set to add a scripting API to GDB is ready for submission. >>> It sets things up so that adding Guile scripting is straightforward. >>> I've cc'd guile-users to apprise them of my progress. >>> I'll spare them the actual set of patches here, >>> though I plan to cc them when submitting the Guile port, >>> their input will be helpful. >>> The actual Guile port is ready ... just have some more docs to write. :-) > > Thanks I reviewed the series. Most comments are inline. I will do a summary here. > > More documentation. The API implementer really needs to know about > what they have to really implement over what is optional. An addition > to the internals manual would be super. At the very least far more > comments in the structures. Righto. My plan is to augment the internals manual in time. > Scripting language priority needs to be looked at in certain > situations. Indeed. My intention is that in cases where it matters the first one wins, and python will stay first in the list. > I documented my thoughts in-line. But as I presume each > scripting language keeps its own meta-data, (IE printer lists), we > will have to refactor the "info > frame-filter/type-printer/pretty-printer" commands to work with all of > them. One thought I have for this is "info guile pretty-printer", etc. That simplifies a lot of things. >From a u/i perspective it has both plusses and minuses, but I like it overall. > Internal naming nits. > > A few comments on some breakpoint struct changes. > > Cheers, > > Phil