From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20216 invoked by alias); 11 Mar 2016 09:58:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20201 invoked by uid 89); 11 Mar 2016 09:58:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*o:Research X-HELO: e06smtp05.uk.ibm.com Received: from e06smtp05.uk.ibm.com (HELO e06smtp05.uk.ibm.com) (195.75.94.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 11 Mar 2016 09:58:27 +0000 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 Mar 2016 09:58:24 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 11 Mar 2016 09:58:22 -0000 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: arnez@linux.vnet.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id B60761B0804B for ; Fri, 11 Mar 2016 09:58:48 +0000 (GMT) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2B9wMa659768844 for ; Fri, 11 Mar 2016 09:58:22 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2B9wLiH029690 for ; Fri, 11 Mar 2016 02:58:21 -0700 Received: from oc1027705133.ibm.com (dyn-9-152-212-180.boeblingen.de.ibm.com [9.152.212.180]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u2B9wLDZ029662 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 11 Mar 2016 02:58:21 -0700 From: Andreas Arnez To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/8] gdb/s390: Fill pseudo register agent expression hooks. References: <1453637529-26972-4-git-send-email-koriakin@0x04.net> <1454853711-18349-1-git-send-email-koriakin@0x04.net> Date: Fri, 11 Mar 2016 09:58:00 -0000 In-Reply-To: <1454853711-18349-1-git-send-email-koriakin@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielnicki\=22's\?\= message of "Sun, 7 Feb 2016 15:01:51 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031109-0021-0000-0000-00000627BE8E X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00173.txt.bz2 On Sun, Feb 07 2016, Marcin Ko=C5=9Bcielnicki wrote: > gdb/ChangeLog: > > * s390-linux-tdep.c (s390_ax_pseudo_register_collect): New function. > (s390_ax_pseudo_register_push_stack): New function. > (s390_gdbarch_init): Fill ax_pseudo_register_collect and > ax_pseudo_register_push_stack hooks. > --- > Added missing comments. > > gdb/ChangeLog | 7 +++++ > gdb/s390-linux-tdep.c | 84 +++++++++++++++++++++++++++++++++++++++++++++= ++++++ > 2 files changed, 91 insertions(+) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index d24cccd..6260040 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,5 +1,12 @@ > 2016-02-07 Marcin Ko=C5=9Bcielnicki >=20=20 > + * s390-linux-tdep.c (s390_ax_pseudo_register_collect): New function. > + (s390_ax_pseudo_register_push_stack): New function. > + (s390_gdbarch_init): Fill ax_pseudo_register_collect and > + ax_pseudo_register_push_stack hooks. > + > +2016-02-07 Marcin Ko=C5=9Bcielnicki > + > * s390-linux-tdep.c (s390_supply_pseudo_pc): New function. > (s390_gdbarch_init): Fill supply_pseudo_pc hook. >=20=20 > diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c > index 144365c..97bd564 100644 > --- a/gdb/s390-linux-tdep.c > +++ b/gdb/s390-linux-tdep.c > @@ -547,6 +547,86 @@ s390_pseudo_register_reggroup_p (struct gdbarch *gdb= arch, int regnum, > return default_register_reggroup_p (gdbarch, regnum, group); > } >=20=20 > +/* The "ax_pseudo_register_collect" gdbarch method. */ > + > +static int > +s390_ax_pseudo_register_collect (struct gdbarch *gdbarch, > + struct agent_expr *ax, int regnum) > +{ > + struct gdbarch_tdep *tdep =3D gdbarch_tdep (gdbarch); > + if (regnum =3D=3D tdep->pc_regnum) > + { > + ax_reg_mask (ax, S390_PSWA_REGNUM); > + } > + else if (regnum =3D=3D tdep->cc_regnum) > + { > + ax_reg_mask (ax, S390_PSWM_REGNUM); > + } > + else if (regnum_is_gpr_full (tdep, regnum)) > + { > + regnum -=3D tdep->gpr_full_regnum; > + ax_reg_mask (ax, S390_R0_REGNUM + regnum); > + ax_reg_mask (ax, S390_R0_UPPER_REGNUM + regnum); > + } > + else if (regnum_is_vxr_full (tdep, regnum)) > + { > + regnum -=3D tdep->v0_full_regnum; > + ax_reg_mask (ax, S390_F0_REGNUM + regnum); > + ax_reg_mask (ax, S390_V0_LOWER_REGNUM + regnum); > + } > + else > + { > + internal_error (__FILE__, __LINE__, _("invalid regnum")); > + } > + return 0; > +} > + > +/* The "ax_pseudo_register_push_stack" gdbarch method. */ > + > +static int > +s390_ax_pseudo_register_push_stack (struct gdbarch *gdbarch, > + struct agent_expr *ax, int regnum) > +{ > + struct gdbarch_tdep *tdep =3D gdbarch_tdep (gdbarch); > + if (regnum =3D=3D tdep->pc_regnum) > + { > + ax_reg (ax, S390_PSWA_REGNUM); > + if (register_size (gdbarch, S390_PSWA_REGNUM) =3D=3D 4) > + { > + ax_zero_ext (ax, 31); > + } > + } > + else if (regnum =3D=3D tdep->cc_regnum) > + { > + ax_reg (ax, S390_PSWM_REGNUM); > + if (register_size (gdbarch, S390_PSWA_REGNUM) =3D=3D 4) > + ax_const_l (ax, 12); > + else > + ax_const_l (ax, 44); > + ax_simple (ax, aop_rsh_unsigned); > + ax_zero_ext (ax, 2); > + } > + else if (regnum_is_gpr_full (tdep, regnum)) > + { > + regnum -=3D tdep->gpr_full_regnum; > + ax_reg (ax, S390_R0_REGNUM + regnum); > + ax_reg (ax, S390_R0_UPPER_REGNUM + regnum); > + ax_const_l (ax, 32); > + ax_simple (ax, aop_lsh); > + ax_simple (ax, aop_bit_or); > + } > + else if (regnum_is_vxr_full (tdep, regnum)) > + { > + /* Too large to stuff on the stack. */ > + return 1; > + } > + else > + { > + internal_error (__FILE__, __LINE__, _("invalid regnum")); > + } > + return 0; > +} > + >=20=20 > /* A helper for s390_software_single_step, decides if an instruction > is a partial-execution instruction that needs to be executed until > @@ -7886,6 +7966,10 @@ s390_gdbarch_init (struct gdbarch_info info, struc= t gdbarch_list *arches) > set_tdesc_pseudo_register_type (gdbarch, s390_pseudo_register_type); > set_tdesc_pseudo_register_reggroup_p (gdbarch, > s390_pseudo_register_reggroup_p); > + set_gdbarch_ax_pseudo_register_collect (gdbarch, > + s390_ax_pseudo_register_collect); > + set_gdbarch_ax_pseudo_register_push_stack > + (gdbarch, s390_ax_pseudo_register_push_stack); > tdesc_use_registers (gdbarch, tdesc, tdesc_data); > set_gdbarch_register_name (gdbarch, s390_register_name); Thanks, this is OK.