From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1786 invoked by alias); 22 Dec 2009 18:35:26 -0000 Received: (qmail 1777 invoked by uid 22791); 22 Dec 2009 18:35:25 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Dec 2009 18:35:18 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBMIZH70003063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 22 Dec 2009 13:35:17 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBMIZGGQ013023; Tue, 22 Dec 2009 13:35:16 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nBMIZFWa024717; Tue, 22 Dec 2009 13:35:16 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 6B7823781B0; Tue, 22 Dec 2009 11:35:15 -0700 (MST) From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/4] dwarf2_physname References: <4B0707E7.5010308@uglyboxes.com> <20091120220927.GA9589@caradoc.them.org> <4B1EAD5C.6060708@redhat.com> <4B2692EE.5090807@redhat.com> <20091217202843.GA11961@caradoc.them.org> Reply-To: Tom Tromey Date: Tue, 22 Dec 2009 18:35:00 -0000 In-Reply-To: <20091217202843.GA11961@caradoc.them.org> (Daniel Jacobowitz's message of "Thu, 17 Dec 2009 15:28:43 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00346.txt.bz2 >>>>> "Daniel" == Daniel Jacobowitz writes: Tom> I am not concerned about this. I don't think -readnow is actually used Tom> -- I can't imagine why anyone would want to use it. And, on a big Tom> program, an unrestricted "info func" or "info type" is probably just a Tom> mistake, like hitting enter too soon. Daniel> [...] Also, does print Daniel> read all symtabs? It doesn't. Keith's patch didn't touch the completion code. This code walks expanded symtabs, and then psymtabs -- it doesn't do any expanding. See symtab.c:default_make_symbol_completion_list. Daniel> I'm not happy with introducing this slowdown. I'd like to at least Daniel> see a profile first - of some smaller example! But I guess you're Daniel> right that -readnow is not useful; maybe I should just let go... :-) My guess is that -readnow is left over from when GDB used mmalloc and could dump symtabs. That's just a guess, though. I do agree that looking at a smaller example would be interesting, because it would isolate the swap effect. Tom