From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71612-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13259 invoked by alias); 30 Mar 2010 16:23:09 -0000
Received: (qmail 13249 invoked by uid 22791); 30 Mar 2010 16:23:08 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Mar 2010 16:23:03 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2UGMqxw026101 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Tue, 30 Mar 2010 12:22:52 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2UGMp8o027299; 	Tue, 30 Mar 2010 12:22:52 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2UGMpRD009948; 	Tue, 30 Mar 2010 12:22:51 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id E2B1437950A; Tue, 30 Mar 2010 10:22:50 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch] Fix crash on NULL rl_prompt
References: <20100329234026.GA23895@host0.dyn.jankratochvil.net> 	<m37hotztsn.fsf@fleche.redhat.com> 	<201003301712.20874.pedro@codesourcery.com>
Reply-To: tromey@redhat.com
Date: Tue, 30 Mar 2010 16:23:00 -0000
In-Reply-To: <201003301712.20874.pedro@codesourcery.com> (Pedro Alves's 	message of "Tue, 30 Mar 2010 17:12:20 +0100")
Message-ID: <m3eij1ye1x.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg01057.txt.bz2

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> It isn't clear to me your patch isn't doing so, FTR.  It could
Pedro> have been a readline change only visible when using a more recent
Pedro> system readline, instead of the version bundled with gdb, for
Pedro> example.

The included readline handles rl_prompt == NULL:

int
rl_set_prompt (prompt)
     const char *prompt;
{
  FREE (rl_prompt);
  rl_prompt = prompt ? savestring (prompt) : (char *)NULL;
  rl_display_prompt = rl_prompt ? rl_prompt : "";

  rl_visible_prompt_length = rl_expand_prompt (rl_prompt);
  return 0;
}

Tom