From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8152 invoked by alias); 26 Apr 2010 20:06:54 -0000 Received: (qmail 8142 invoked by uid 22791); 26 Apr 2010 20:06:53 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Apr 2010 20:06:44 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3QK6cqY000719 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 26 Apr 2010 16:06:38 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3QK6brM012678; Mon, 26 Apr 2010 16:06:38 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3QK6Yvt019360; Mon, 26 Apr 2010 16:06:37 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 57CBB37820A; Mon, 26 Apr 2010 14:06:34 -0600 (MDT) From: Tom Tromey To: Matthew Gretton-Dann Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Gracefully handle not being able to access a DWARF register number References: <1272295674.16160.23.camel@e102111-lin.cambridge.arm.com> Reply-To: tromey@redhat.com Date: Mon, 26 Apr 2010 20:06:00 -0000 In-Reply-To: <1272295674.16160.23.camel@e102111-lin.cambridge.arm.com> (Matthew Gretton-Dann's message of "Mon, 26 Apr 2010 16:27:54 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00892.txt.bz2 >>>>> "Matthew" == Matthew Gretton-Dann writes: Matthew> The attached patch changes these internal errors into warnings, and Matthew> tries to return something sensible to the user. Why a warning and not an error? It seems to me that an error is preferable to returning incorrect information. Matthew> Please could someone review and comment on the patch, and then if this Matthew> is approved can they please commit it as I don't have commit rights. Do you have copyright assignment paperwork in place? Matthew> + warning (_("Unable to access DWARF register number %" BFD_VMA_FMT "d"), Matthew> + p->v.expr.value); I think there is some other way to print a CORE_ADDR, but I forget what it is. BFD_VMA_FMT seems suspect, just because it is not used anywhere else in gdb. Tom