From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11580 invoked by alias); 20 Jun 2010 18:41:18 -0000 Received: (qmail 11571 invoked by uid 22791); 20 Jun 2010 18:41:18 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 20 Jun 2010 18:41:14 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5KIewSL015396 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 20 Jun 2010 14:40:58 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5KIevX9027781; Sun, 20 Jun 2010 14:40:57 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o5KIetVk008002; Sun, 20 Jun 2010 14:40:56 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 86CA1378850; Sun, 20 Jun 2010 12:40:55 -0600 (MDT) From: Tom Tromey To: Doug Evans Cc: Pierre Muller , Hui Zhu , gdb-patches@sourceware.org, Pedro Alves , Stan Shebs , Eli Zaretskii , Michael Snyder Subject: Re: [RFA-new version][gdbserver] x86 agent expression bytecode compiler (speed up conditional tracepoints) References: <201006071700.28706.pedro@codesourcery.com> <4C19222C.2000208@codesourcery.com> <201006162016.18181.pedro@codesourcery.com> <4C19265B.7090502@codesourcery.com> <4C1A6362.3020306@vmware.com> <-3945058798826177264@unknownmsgid> Reply-To: tromey@redhat.com Date: Sun, 20 Jun 2010 18:41:00 -0000 In-Reply-To: (Doug Evans's message of "Sun, 20 Jun 2010 08:30:40 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00447.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> That's weird. Doug> Ian's approach involves removing the "if-always-true" test completely Doug> leaving just an asm. Doug> Can you send me the patch of Ian's that you tried? I think that since Ian's patch works for Pierre, and since it seems reasonable on its own merits, it is ok. So, somebody please check it in. If this is not ok with somebody, it is fine to re-fix it a different way later. In the short run it is nice to fix the build. Tom