From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2164 invoked by alias); 19 Aug 2010 20:26:37 -0000 Received: (qmail 2156 invoked by uid 22791); 19 Aug 2010 20:26:37 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Aug 2010 20:26:32 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7JKQUY8009779 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 19 Aug 2010 16:26:31 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7JKQUTm018381; Thu, 19 Aug 2010 16:26:30 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7JKQTjc005167; Thu, 19 Aug 2010 16:26:30 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 7F037378975; Thu, 19 Aug 2010 14:26:29 -0600 (MDT) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch 1/2] Use custom hash function with bcache [Re: [RFC] Use custom hash function with bcache] References: <4C6946E1.6000709@redhat.com> <4C6D5C83.3050602@redhat.com> Date: Thu, 19 Aug 2010 20:26:00 -0000 In-Reply-To: <4C6D5C83.3050602@redhat.com> (sami wagiaalla's message of "Thu, 19 Aug 2010 12:32:03 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00358.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> +/* Forwarding function for memcmp. */ Sami> +//bcache_memcmp () Remove. Sami> +bcache_xmalloc (unsigned long (*hash_function)(const void*, int length), Sami> + int (*compare_function)(const void*, const void*, int length)) Space in "void *". Sami> +extern struct bcache *bcache_xmalloc ( Sami> + unsigned long (*hash_function)(const void*, int length), Sami> + int (*compare_function)(const void*, const void*, int length)); Likewise. Sami> /* psymbol is static so that there will be no uninitialized gaps in the Sami> structure which might contain random data, causing cache misses in Sami> bcache. */ Sami> - static struct partial_symbol psymbol; Sami> + struct partial_symbol psymbol; Remove the comment here. It is no longer valid. Sami> /* However, we must ensure that the entire 'value' field has been Sami> zeroed before assigning to it, because an assignment may not We probably don't need this comment or the memset any more. Tom