From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79566-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29619 invoked by alias); 11 Mar 2011 21:44:05 -0000
Received: (qmail 29611 invoked by uid 22791); 11 Mar 2011 21:44:05 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 21:44:01 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2BLi0nU000748	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 11 Mar 2011 16:44:00 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2BLhxPC007876;	Fri, 11 Mar 2011 16:44:00 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2BLhxhX029642;	Fri, 11 Mar 2011 16:43:59 -0500
Received: by opsy.redhat.com (Postfix, from userid 500)	id E0E2A3797CD; Fri, 11 Mar 2011 14:43:58 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] python/py-breakpoint.c (bppy_set_condition): Stop memory leak.
References: <4D7A944E.20801@vmware.com>
Date: Fri, 11 Mar 2011 21:57:00 -0000
In-Reply-To: <4D7A944E.20801@vmware.com> (Michael Snyder's message of "Fri, 11	Mar 2011 13:29:50 -0800")
Message-ID: <m3ei6d49k1.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00679.txt.bz2

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> 2011-03-11  Michael Snyder  <msnyder@vmware.com>
Michael> 	* python/py-breakpoint.c (bppy_set_condition): Stop memory leak.

This isn't sufficient to stop the leak.

Michael>    GDB_PY_SET_HANDLE_EXCEPTION (except);

This can return.

We aren't really using cleanups in "pure python" functions like this one.
You can just explicitly xfree `exp' after the TRY_CATCH.
However, note the `exp = ""' branch.

Tom