From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30042 invoked by alias); 6 Jul 2011 14:36:44 -0000 Received: (qmail 30034 invoked by uid 22791); 6 Jul 2011 14:36:43 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 14:36:25 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p66EaN46008545 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jul 2011 10:36:23 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p66EaN82028156; Wed, 6 Jul 2011 10:36:23 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p66EaMMX019805; Wed, 6 Jul 2011 10:36:22 -0400 From: Tom Tromey To: Hui Zhu Cc: gdb-patches ml Subject: Re: [RFA/tracepoint] Make GDB can work with some old GDB server References: Date: Wed, 06 Jul 2011 14:40:00 -0000 In-Reply-To: (Hui Zhu's message of "Wed, 6 Jul 2011 10:45:05 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00188.txt.bz2 >>>>> ">" == Hui Zhu writes: >> Thanks for your review. >> Fixed and checked in. I didn't intend to approve this. I am sorry this was not clear. I do not know remote.c well enough to approve a subtle patch like this. >> Do you think this patch is OK for 7.3 branch? No. Tom