From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82611-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 719 invoked by alias); 25 Jul 2011 19:26:08 -0000
Received: (qmail 707 invoked by uid 22791); 25 Jul 2011 19:26:07 -0000
X-SWARE-Spam-Status: No, hits=-7.5 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Jul 2011 19:25:54 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6PJPi2k002059	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 25 Jul 2011 15:25:44 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6PJPh1C017072;	Mon, 25 Jul 2011 15:25:44 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6PJPglJ006095;	Mon, 25 Jul 2011 15:25:42 -0400
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Paul Pluzhnikov <ppluzhnikov@google.com>
Subject: Re: [RFC][patch] Make DCACHE_LINE runtime-settable
References: <20110722222025.ED9B6190B14@elbrus2.mtv.corp.google.com>	<m3tyaatnu5.fsf@fleche.redhat.com>	<CALoOobOyyOOBKBOy97se2jcnpWMwQ00_Q9ht775NiAed-HxEsA@mail.gmail.com>	<201107252021.39702.pedro@codesourcery.com>
Date: Mon, 25 Jul 2011 19:33:00 -0000
In-Reply-To: <201107252021.39702.pedro@codesourcery.com> (Pedro Alves's	message of "Mon, 25 Jul 2011 20:21:39 +0100")
Message-ID: <m3ei1erwll.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00706.txt.bz2

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

>> +/* BLOCK_FUNC routine for dcache_free.  */
>> +
>> +static void
>> +free_block (struct dcache_block *block, void *param)
>> +{
>> +  free (block);

Pedro> xfree.

This one is just moving code from one spot to another.
I don't mind it if Paul wants to fix it, but I think as a rule we
shouldn't "review the context" and make patch submitters fix nits which
already appear in the source.

Tom