From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11311 invoked by alias); 3 Sep 2011 10:09:03 -0000 Received: (qmail 11302 invoked by uid 22791); 3 Sep 2011 10:09:02 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 03 Sep 2011 10:08:44 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p83A8abj005061 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 Sep 2011 06:08:36 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p83A8YmQ018176; Sat, 3 Sep 2011 06:08:35 -0400 From: Phil Muldoon To: Pedro Alves Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [patch] [python] Prompt substitution References: <201108302118.18505.pedro@codesourcery.com> <201109021822.02655.pedro@codesourcery.com> Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Sat, 03 Sep 2011 10:15:00 -0000 In-Reply-To: <201109021822.02655.pedro@codesourcery.com> (Pedro Alves's message of "Fri, 2 Sep 2011 18:22:02 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00050.txt.bz2 Pedro Alves writes: > On Tuesday 30 August 2011 21:33:24, Phil Muldoon wrote: >> I think in the case, display_gdb_prompt is just displaying what GDB >> knows to be the prompt. If you delete the hook, whatever was the prompt >> when the prompt was set will remain the prompt. So the hook set the >> prompt whenever in time, and when you delete the hook, it won't restore >> what the old prompt was. So if you disable the prompt, then set prompt >> foo, then you will get "foo" now until you change it again manually. In >> the case of "guarded prompt" (IE >) it won't attempt to alter that >> display at all. > > I see. I assumed that the python hook worked by overriding > "set prompt", but that the result wouldn't be seen by "show prompt". > That is, set/show prompt always worked at the "this is what > I want the prompt to look like if no scripting overrides it" level. > Okay, I preserved the current behaviour. Matt's new (uncommitted) > py-prompt.exp tests were great for making sure I did. :-) Yeah this was a port from archer, something I did not originally write, but has been asked for since, well, forever. I'm not strongly swayed by the behavior, as it is, or, as in your scenario working around set_prompt. Tom might have other thoughts as I think he wrote most of this stuff. But FWIW, I don't mind if you change it to your method -- both seem equally valid use-cases. Cheers, Phil