From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18797 invoked by alias); 20 Oct 2011 14:10:05 -0000 Received: (qmail 18750 invoked by uid 22791); 20 Oct 2011 14:10:03 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Oct 2011 14:09:44 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9KE9hVE022639 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Oct 2011 10:09:43 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9KE9hIY009407; Thu, 20 Oct 2011 10:09:43 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9KE9fuC018430; Thu, 20 Oct 2011 10:09:42 -0400 From: Tom Tromey To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: [patch] [python] Use TRY_CATCH in some functions. References: Date: Thu, 20 Oct 2011 14:23:00 -0000 In-Reply-To: (Phil Muldoon's message of "Thu, 20 Oct 2011 13:58:07 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00556.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> + if (except.reason < 0) Phil> + { Phil> + PyErr_Format (except.reason == RETURN_QUIT Phil> + ? PyExc_KeyboardInterrupt : PyExc_RuntimeError, Phil> + "%s", except.message); Phil> + return NULL; Tom> Why not GDB_PY_HANDLE_EXCEPTION here? Tom> (And also fix up typy_lookup_typename to do the same.) Phil> Because typy_lookup_typename and typy_lookup_type are helper Phil> functions that return struct type, while GDB_PY_HANDLE_EXCEPTION Phil> returns a PyObject (from gdbpy_convert_exception). Should we have Phil> a macro that builds an exception without returning one? We should, Phil> I think. But I was not going to do that in this patch context. Ok, I see. Thanks. I think both those functions should use gdbpy_convert_exception, though, instead of replicating the exception-conversion logic themselves. Tom