From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24828 invoked by alias); 14 Aug 2013 19:29:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24816 invoked by uid 89); 14 Aug 2013 19:29:21 -0000 X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 14 Aug 2013 19:29:20 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7EJTGWR025214 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 14 Aug 2013 15:29:16 -0400 Received: from psique (ovpn-113-52.phx2.redhat.com [10.3.113.52]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r7EJTCMJ000390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 14 Aug 2013 15:29:14 -0400 From: Sergio Durigan Junior To: Samuel Bronson Cc: gdb-patches@sourceware.org, Doug Evans Subject: Re: [PATCH v2] ARM Linux support for `catch syscall' References: X-URL: http://www.redhat.com Date: Wed, 14 Aug 2013 19:29:00 -0000 In-Reply-To: (Samuel Bronson's message of "Wed, 31 Jul 2013 20:47:23 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00388.txt.bz2 Hi Samuel, Thanks for the patch. A few comments. On Wednesday, July 31 2013, Samuel Bronson wrote: > This time, it passes all the tests and comes with a nearly complete > XML file (plus a script that can nearly regenerate the XML file). So the XML file is not complete? What's missing? IMO it should certainly be complete, even if the script can't generate it entirely (in which case it should be hand editted). > diff --git a/gdb/syscalls/arm-linux.py b/gdb/syscalls/arm-linux.py > new file mode 100755 > index 0000000..0814dd4 > --- /dev/null > +++ b/gdb/syscalls/arm-linux.py > @@ -0,0 +1,60 @@ > +# Copyright (C) 2013 Free Software Foundation, Inc. > + > +# Copying and distribution of this file, with or without modification, > +# are permitted in any medium without royalty provided the copyright > +# notice and this notice are preserved. This file is offered as-is, > +# without any warranty. > + > +import sys > +import re > +import time > + > +infname = sys.argv[1] > +inf = file(infname) > + > +print("""\ > + > + > + > + > + > + > + > +""" % (time.strftime("%Y"), infname)) > + > +def record(name, number, comment=None): > + #nm = 'name="%s"' % name > + #s = ' ' % (nm, number) > + s = ' ' % (name, number) > + if comment: > + s += ' ' % comment > + print(s) > + > +for line in inf: > + m = re.match(r'^#define __NR_(\w+)\s+\(__NR_SYSCALL_BASE\+\s*(\d+)\)', > + line) > + if m: > + record(m.group(1), int(m.group(2))) > + continue > + > + m = re.match(r'^\s+/\* (\d+) was sys_(\w+) \*/$', line) > + if m: > + record(m.group(2), int(m.group(1)), 'removed') I don't get the 'removed' comment. Looking at , I don't see the syscalls marked as "removed" in the XML file below. Where did they come from? > + > + m = re.match(r'^#define __ARM_NR_(\w+)\s+\(__ARM_NR_BASE\+\s*(\d+)\)', > + line) > + if m: > + record('ARM_'+m.group(1), 0x0f0000+int(m.group(2))) > + continue > + > +print('') > diff --git a/gdb/syscalls/arm-linux.xml b/gdb/syscalls/arm-linux.xml > new file mode 100644 > index 0000000..b35125c > --- /dev/null > +++ b/gdb/syscalls/arm-linux.xml > @@ -0,0 +1,398 @@ > + > +