From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10829 invoked by alias); 12 Apr 2014 16:40:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10819 invoked by uid 89); 12 Apr 2014 16:40:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-pd0-f169.google.com Received: from mail-pd0-f169.google.com (HELO mail-pd0-f169.google.com) (209.85.192.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 12 Apr 2014 16:40:47 +0000 Received: by mail-pd0-f169.google.com with SMTP id fp1so6516435pdb.0 for ; Sat, 12 Apr 2014 09:40:45 -0700 (PDT) X-Received: by 10.66.147.130 with SMTP id tk2mr34334708pab.125.1397320845344; Sat, 12 Apr 2014 09:40:45 -0700 (PDT) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id db3sm23002476pbb.10.2014.04.12.09.40.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Apr 2014 09:40:44 -0700 (PDT) From: Doug Evans To: Andy Wingo Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/9] Allow GDB to build against unreleased Guile 2.2 References: <1397060028-18158-1-git-send-email-wingo@igalia.com> <1397060028-18158-2-git-send-email-wingo@igalia.com> Date: Sat, 12 Apr 2014 16:40:00 -0000 In-Reply-To: <1397060028-18158-2-git-send-email-wingo@igalia.com> (Andy Wingo's message of "Wed, 9 Apr 2014 18:13:40 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00236.txt.bz2 Andy Wingo writes: > * gdb/configure: > * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2. > --- > gdb/configure | 5 +++-- > gdb/configure.ac | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gdb/configure b/gdb/configure > index fd61bb5..307c6c9 100755 > --- a/gdb/configure > +++ b/gdb/configure > @@ -3,7 +3,7 @@ > # Generated by GNU Autoconf 2.64. > # > # Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001, > -# 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 Free Software > +# 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2014 Free Software > # Foundation, Inc. > # > # This configure script is free software; the Free Software Foundation > @@ -8750,7 +8750,8 @@ fi > > > > -try_guile_versions="guile-2.0" > + > +try_guile_versions="guile-2.2 guile-2.0" > have_libguile=no > case "${with_guile}" in > no) > diff --git a/gdb/configure.ac b/gdb/configure.ac > index 494d711..ff84a2e 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -1154,7 +1154,7 @@ AC_MSG_RESULT([$with_guile]) > dnl We check guile with pkg-config. > AC_PATH_PROG(pkg_config_prog_path, pkg-config, missing) > > -try_guile_versions="guile-2.0" > +try_guile_versions="guile-2.2 guile-2.0" > have_libguile=no > case "${with_guile}" in > no) Hi. This is ok with two nits: 1) ChangeLog entries are included in the email as they appear in the file itself (but not as a patch). E.g., for future reference, replace * gdb/configure: * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2. with 2014-04-09 Andy Wingo * gdb/configure: * gdb/configure.ac (try_guile_versions): Allow building with guile 2.2. I realize it can be cumbersome, but it's the convention we have. 2) The change to configure is small, so it's not a big a deal, but, for reference sake, the convention here is to not include changes to machine generated files in patches submitted to the list. Plus I wouldn't expect a change to the Copyright year in configure. --- As I say these are just nits, but they are community rules so I'm obligated to forward them on. btw, this patch is small enough to not require one, and while I wouldn't doubt that you have a copyright assignment for Guile changes :-), do you have one for gdb? I can imagine having a blanket assignment for everything, just checking.