From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-112938-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8186 invoked by alias); 2 Jun 2014 04:04:38 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 8170 invoked by uid 89); 2 Jun 2014 04:04:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-pb0-f54.google.com
Received: from mail-pb0-f54.google.com (HELO mail-pb0-f54.google.com) (209.85.160.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 02 Jun 2014 04:04:35 +0000
Received: by mail-pb0-f54.google.com with SMTP id jt11so3751425pbb.41        for <gdb-patches@sourceware.org>; Sun, 01 Jun 2014 21:04:33 -0700 (PDT)
X-Received: by 10.66.148.70 with SMTP id tq6mr37036233pab.56.1401681872380;        Sun, 01 Jun 2014 21:04:32 -0700 (PDT)
Received: from seba.sebabeach.org.gmail.com (173-13-178-50-sfba.hfc.comcastbusiness.net. [173.13.178.50])        by mx.google.com with ESMTPSA id bu1sm17889199pbb.54.2014.06.01.21.04.31        for <multiple recipients>        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Sun, 01 Jun 2014 21:04:31 -0700 (PDT)
From: Doug Evans <xdje42@gmail.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/4 v19] Add support for lookup, overload resolution and invocation of xmethods of C++ classes
References: <CAGyQ6gx1fP+6UFFcgt+4V=U0gVks6k4uQYHBAV4VzS=sbbrRLQ@mail.gmail.com>
Date: Mon, 02 Jun 2014 04:04:00 -0000
In-Reply-To: <CAGyQ6gx1fP+6UFFcgt+4V=U0gVks6k4uQYHBAV4VzS=sbbrRLQ@mail.gmail.com>	(Siva Chandra's message of "Fri, 30 May 2014 16:01:12 -0700")
Message-ID: <m3egz8dkjl.fsf@sspiff.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2014-06/txt/msg00010.txt.bz2

Siva Chandra <sivachandra@google.com> writes:

> No changes from v18.
>
> ChangeLog
>
> 2014-05-30  Siva Chandra Reddy  <sivachandra@google.com>
>
>         * eval.c (evaluate_subexp_standard): Call the xmethod if the
>         best match method returned by find_overload_match is an xmethod.
>         * valarith.c (value_x_binop, value_x_unop): Call the xmethod if
>         the best matching operator returned by find_overload_match is an
>         xmethod.
>         * valops.c: #include "extension.h".
>         (find_method_list): Add "fn_list" and "xm_worker_vec" arguments.
>         Return void.  The list of matching source methods is returned in
>         "fn_list" and a vector of matching debug method workers is
>         returned in "xm_worker_vec".  Update all callers.
>         (value_find_oload_method_list): Likewise.
>         (find_oload_champ): Add "xm_worker_vec" parameter.  If it is
>         non-NULL, then the index of the best matching method in this
>         vector is returned.  Update all callers.
>         (find_overload_match): Include xmethods while performing overload
>         resolution.

LGTM