From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5201 invoked by alias); 7 Nov 2014 08:59:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5178 invoked by uid 89); 7 Nov 2014 08:59:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 X-HELO: mail-pd0-f171.google.com Received: from mail-pd0-f171.google.com (HELO mail-pd0-f171.google.com) (209.85.192.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 07 Nov 2014 08:59:55 +0000 Received: by mail-pd0-f171.google.com with SMTP id r10so2939341pdi.30 for ; Fri, 07 Nov 2014 00:59:53 -0800 (PST) X-Received: by 10.66.234.100 with SMTP id ud4mr10741038pac.36.1415350793625; Fri, 07 Nov 2014 00:59:53 -0800 (PST) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by mx.google.com with ESMTPSA id eb7sm6716356pad.9.2014.11.07.00.59.52 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Nov 2014 00:59:52 -0800 (PST) From: Doug Evans To: Yao Qi Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH 5/9] Rename some "aux" functions. References: <87k33luhpw.fsf@codesourcery.com> <878uk0vqcn.fsf@codesourcery.com> Date: Fri, 07 Nov 2014 08:59:00 -0000 In-Reply-To: <878uk0vqcn.fsf@codesourcery.com> (Yao Qi's message of "Tue, 28 Oct 2014 11:13:28 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00128.txt.bz2 Yao Qi writes: > Doug Evans writes: > >> If you want to name it lookup_symbol_in_objfile_symtabs then I'd be ok >> with that. > > Yes, that is good to me. Here is what I committed. 2014-11-06 Doug Evans * symtab.c (lookup_local_symbol): Renamed from lookup_symbol_aux_local. All callers updated. (lookup_symbol_in_all_objfiles): Renamed from lookup_symbol_aux_symtabs. All callers updated. (lookup_symbol_via_quick_fns): Renamed from lookup_symbol_aux_quick. All callers updated. (lookup_symbol_in_objfile_symtabs): Renamed from lookup_symbol_aux_objfile. All callers updated. diff --git a/gdb/symtab.c b/gdb/symtab.c index 3c2e277..6f483bf 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -74,21 +74,21 @@ static struct symbol *lookup_symbol_aux (const char *name, struct field_of_this_result *); static -struct symbol *lookup_symbol_aux_local (const char *name, - const struct block *block, - const domain_enum domain, - enum language language); +struct symbol *lookup_local_symbol (const char *name, + const struct block *block, + const domain_enum domain, + enum language language); static -struct symbol *lookup_symbol_aux_symtabs (int block_index, - const char *name, - const domain_enum domain); +struct symbol *lookup_symbol_in_all_objfiles (int block_index, + const char *name, + const domain_enum domain); static -struct symbol *lookup_symbol_aux_quick (struct objfile *objfile, - int block_index, - const char *name, - const domain_enum domain); +struct symbol *lookup_symbol_via_quick_fns (struct objfile *objfile, + int block_index, + const char *name, + const domain_enum domain); extern initialize_file_ftype _initialize_symtab; @@ -1424,7 +1424,7 @@ lookup_symbol_aux (const char *name, const struct block *block, /* Search specified block and its superiors. Don't search STATIC_BLOCK or GLOBAL_BLOCK. */ - sym = lookup_symbol_aux_local (name, block, domain, language); + sym = lookup_local_symbol (name, block, domain, language); if (sym != NULL) return sym; @@ -1482,13 +1482,13 @@ lookup_static_symbol (const char *name, const domain_enum domain) struct objfile *objfile; struct symbol *sym; - sym = lookup_symbol_aux_symtabs (STATIC_BLOCK, name, domain); + sym = lookup_symbol_in_all_objfiles (STATIC_BLOCK, name, domain); if (sym != NULL) return sym; ALL_OBJFILES (objfile) { - sym = lookup_symbol_aux_quick (objfile, STATIC_BLOCK, name, domain); + sym = lookup_symbol_via_quick_fns (objfile, STATIC_BLOCK, name, domain); if (sym != NULL) return sym; } @@ -1500,9 +1500,9 @@ lookup_static_symbol (const char *name, const domain_enum domain) Don't search STATIC_BLOCK or GLOBAL_BLOCK. */ static struct symbol * -lookup_symbol_aux_local (const char *name, const struct block *block, - const domain_enum domain, - enum language language) +lookup_local_symbol (const char *name, const struct block *block, + const domain_enum domain, + enum language language) { struct symbol *sym; const struct block *static_block = block_static_block (block); @@ -1612,8 +1612,8 @@ lookup_global_symbol_from_objfile (const struct objfile *main_objfile, } } - sym = lookup_symbol_aux_quick ((struct objfile *) objfile, GLOBAL_BLOCK, - name, domain); + sym = lookup_symbol_via_quick_fns ((struct objfile *) objfile, + GLOBAL_BLOCK, name, domain); if (sym) return sym; } @@ -1627,8 +1627,8 @@ lookup_global_symbol_from_objfile (const struct objfile *main_objfile, static symbols. */ static struct symbol * -lookup_symbol_aux_objfile (struct objfile *objfile, int block_index, - const char *name, const domain_enum domain) +lookup_symbol_in_objfile_symtabs (struct objfile *objfile, int block_index, + const char *name, const domain_enum domain) { struct symbol *sym = NULL; const struct blockvector *bv; @@ -1650,19 +1650,20 @@ lookup_symbol_aux_objfile (struct objfile *objfile, int block_index, return NULL; } -/* Same as lookup_symbol_aux_objfile, except that it searches all - objfiles. Return the first match found. */ +/* Wrapper around lookup_symbol_in_objfile_symtabs to search all objfiles. + Returns the first match found. */ static struct symbol * -lookup_symbol_aux_symtabs (int block_index, const char *name, - const domain_enum domain) +lookup_symbol_in_all_objfiles (int block_index, const char *name, + const domain_enum domain) { struct symbol *sym; struct objfile *objfile; ALL_OBJFILES (objfile) { - sym = lookup_symbol_aux_objfile (objfile, block_index, name, domain); + sym = lookup_symbol_in_objfile_symtabs (objfile, block_index, name, + domain); if (sym) return sym; } @@ -1670,7 +1671,7 @@ lookup_symbol_aux_symtabs (int block_index, const char *name, return NULL; } -/* Wrapper around lookup_symbol_aux_objfile for search_symbols. +/* Wrapper around lookup_symbol_in_objfile_symtabs for search_symbols. Look up LINKAGE_NAME in DOMAIN in the global and static blocks of OBJFILE and all related objfiles. */ @@ -1696,11 +1697,11 @@ lookup_symbol_in_objfile_from_linkage_name (struct objfile *objfile, { struct symbol *sym; - sym = lookup_symbol_aux_objfile (cur_objfile, GLOBAL_BLOCK, - modified_name, domain); + sym = lookup_symbol_in_objfile_symtabs (cur_objfile, GLOBAL_BLOCK, + modified_name, domain); if (sym == NULL) - sym = lookup_symbol_aux_objfile (cur_objfile, STATIC_BLOCK, - modified_name, domain); + sym = lookup_symbol_in_objfile_symtabs (cur_objfile, STATIC_BLOCK, + modified_name, domain); if (sym != NULL) { do_cleanups (cleanup); @@ -1727,12 +1728,12 @@ Internal: %s symbol `%s' found in %s psymtab but not in symtab.\n\ name, symtab_to_filename_for_display (symtab), name, name); } -/* A helper function for lookup_symbol_aux that interfaces with the - "quick" symbol table functions. */ +/* A helper function for various lookup routines that interfaces with + the "quick" symbol table functions. */ static struct symbol * -lookup_symbol_aux_quick (struct objfile *objfile, int block_index, - const char *name, const domain_enum domain) +lookup_symbol_via_quick_fns (struct objfile *objfile, int block_index, + const char *name, const domain_enum domain) { struct symtab *symtab; const struct blockvector *bv; @@ -1773,7 +1774,7 @@ basic_lookup_symbol_nonlocal (const char *name, not it would be appropriate to search the current global block here as well. (That's what this code used to do before the is_a_field_of_this check was moved up.) On the one hand, it's - redundant with the lookup_symbol_aux_symtabs search that happens + redundant with the lookup_symbol_in_all_objfiles search that happens next. On the other hand, if decode_line_1 is passed an argument like filename:var, then the user presumably wants 'var' to be searched for in filename. On the third hand, there shouldn't be @@ -1842,11 +1843,11 @@ lookup_symbol_global_iterator_cb (struct objfile *objfile, gdb_assert (data->result == NULL); - data->result = lookup_symbol_aux_objfile (objfile, GLOBAL_BLOCK, - data->name, data->domain); + data->result = lookup_symbol_in_objfile_symtabs (objfile, GLOBAL_BLOCK, + data->name, data->domain); if (data->result == NULL) - data->result = lookup_symbol_aux_quick (objfile, GLOBAL_BLOCK, - data->name, data->domain); + data->result = lookup_symbol_via_quick_fns (objfile, GLOBAL_BLOCK, + data->name, data->domain); /* If we found a match, tell the iterator to stop. Otherwise, keep going. */