From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102386 invoked by alias); 20 Jan 2016 18:44:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102373 invoked by uid 89); 20 Jan 2016 18:44:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=gnu_vector.exp, gnu_vectorexp, UD:gnu_vector.exp X-HELO: e06smtp13.uk.ibm.com Received: from e06smtp13.uk.ibm.com (HELO e06smtp13.uk.ibm.com) (195.75.94.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 20 Jan 2016 18:44:28 +0000 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 20 Jan 2016 18:44:25 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 20 Jan 2016 18:44:23 -0000 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: arnez@linux.vnet.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id C82462190046 for ; Wed, 20 Jan 2016 18:44:10 +0000 (GMT) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0KIiMYQ8520144 for ; Wed, 20 Jan 2016 18:44:22 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0KIiMlF009930 for ; Wed, 20 Jan 2016 13:44:22 -0500 Received: from oc1027705133.ibm.com (dyn-9-152-212-188.boeblingen.de.ibm.com [9.152.212.188]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u0KIiLHh009920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 20 Jan 2016 13:44:22 -0500 From: Andreas Arnez To: Yao Qi Cc: gdb-patches@sourceware.org, Yao Qi Subject: Re: [PATCH v2] gnu_vector.exp: Respect `should_kfail' for PR8549 References: <86k2n4s6n6.fsf@gmail.com> Date: Wed, 20 Jan 2016 18:44:00 -0000 In-Reply-To: <86k2n4s6n6.fsf@gmail.com> (Yao Qi's message of "Wed, 20 Jan 2016 13:49:17 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012018-0013-0000-0000-0000085A69AB X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00488.txt.bz2 On Wed, Jan 20 2016, Yao Qi wrote: > Andreas Arnez writes: > > Hi Andreas, > Patch is OK to me, > >> -gdb_test "p res" "\\{4, 2, 7, 6\\}.*" "verify vector return value" >> +set test "verify vector return value" >> +gdb_test_multiple "p res" $test { >> + -re ".*= \\{4, 2, 7, 6\\}\r\n.*$gdb_prompt $" { >> + pass $test >> + } >> + -re ".*= \\{.*\\}\r\n.*$gdb_prompt $" { >> + if { $should_kfail } { >> + # GDB had not actually set the return value, likely due to >> + # PR8549. So accept any return value and emit a KFAIL. > > Nit, we need a space between "PR" and "8549". OK, I've committed the patch with that change. Thanks! -- Andreas