From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56534 invoked by alias); 6 Feb 2017 18:48:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56482 invoked by uid 89); 6 Feb 2017 18:48:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=Philipp, philipp, Rudo, rudo X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Feb 2017 18:48:18 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v16IXo4e070588 for ; Mon, 6 Feb 2017 13:48:08 -0500 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0a-001b2d01.pphosted.com with ESMTP id 28euyfyefh-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 06 Feb 2017 13:48:08 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 Feb 2017 18:48:06 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 6 Feb 2017 18:48:02 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4DA5617D8056; Mon, 6 Feb 2017 18:51:05 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v16Im2vv13107516; Mon, 6 Feb 2017 18:48:02 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6A14CA4055; Mon, 6 Feb 2017 18:47:58 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3E590A4051; Mon, 6 Feb 2017 18:47:58 +0000 (GMT) Received: from oc1027705133.ibm.com (unknown [9.152.212.222]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 6 Feb 2017 18:47:58 +0000 (GMT) From: Andreas Arnez To: Yao Qi Cc: Luis Machado , Philipp Rudo , gdb-patches@sourceware.org, peter.griffin@linaro.org, yao.qi@arm.com Subject: Re: [RFC 7/7] Add S390 support for linux-kernel target References: <20170112113217.48852-1-prudo@linux.vnet.ibm.com> <20170112113217.48852-8-prudo@linux.vnet.ibm.com> <4afd49cd-534c-9f34-e389-6e4f6e686831@codesourcery.com> <20170206155222.GF11916@E107787-LIN> Date: Mon, 06 Feb 2017 18:48:00 -0000 In-Reply-To: <20170206155222.GF11916@E107787-LIN> (Yao Qi's message of "Mon, 6 Feb 2017 15:52:22 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17020618-0016-0000-0000-000004395558 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17020618-0017-0000-0000-0000265A2BC4 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-06_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702060179 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00136.txt.bz2 On Mon, Feb 06 2017, Yao Qi wrote: > On 17-01-12 11:08:59, Luis Machado wrote: >> On 01/12/2017 05:32 AM, Philipp Rudo wrote: >> > >> >diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c >> >index 054c6d5..f436a74 100644 >> >--- a/gdb/s390-linux-tdep.c >> >+++ b/gdb/s390-linux-tdep.c >> >> I wonder if we should put the new lk-specific code in its own file, >> like s390-lk-tdep.c or something. It would make thing a bit more >> clear and would pollute the current s390-linux-tdep.c file? >> > > +1. +1. The Linux kernel runtime will be the second "operating system" supported by GDB for the s390/s390x architectures. So if we stick to the usual naming, we will have three components instead of one: 1. s390-tdep -- common 2. s390-linux-tdep -- Linux user-space-specific 3. s390-lk-tdep -- Linux kernel-specific -- Andreas