From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50938-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30593 invoked by alias); 24 Sep 2007 21:49:01 -0000
Received: (qmail 30534 invoked by uid 22791); 24 Sep 2007 21:49:00 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 24 Sep 2007 21:48:59 +0000
Received: (qmail 28234 invoked from network); 24 Sep 2007 21:48:57 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 24 Sep 2007 21:48:57 -0000
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: Fix qOffsets handling
References: <m3wsuj8ywc.fsf@codesourcery.com> 	<20070921221937.GB3963@adacore.com>
From: Jim Blandy <jimb@codesourcery.com>
Date: Mon, 24 Sep 2007 21:49:00 -0000
In-Reply-To: <20070921221937.GB3963@adacore.com> (Joel Brobecker's message of "Fri, 21 Sep 2007 15:19:37 -0700")
Message-ID: <m3d4w7rayf.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-09/txt/msg00347.txt.bz2


Joel Brobecker <brobecker@adacore.com> writes:
>> Daniel Jacobowitz has approved this change off-list, and asked me to
>> suggest it be included on the 6.7 branch as well.  I'll wait for
>> further comments here, and commit to trunk on Monday; Joel, is this
>> okay for the branch?
>
> Sure! I agree it should be applied to the branch as well.
>> 
>> gdb/ChangeLog:
>> 2007-09-21  Jim Blandy  <jimb@codesourcery.com>
>> 
>> 	* symfile.h (struct symfile_segment_data): Doc fixes.
>> 	* symfile.c (symfile_map_offsets_to_segments): Doc fixes.
>> 	Assert that we were passed some loaded segment addresses,
>> 	and that sections' segment numbers are valid.
>> 	Simplify offset calculation.
>> 	* remote.c (get_offsets): Clarify selection of relocate-by-segment
>> 	strategy, and set num_segments correctly.  Delete redundant
>> 	assignments to do_sections.

I've committed this to trunk and branch.