From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2088 invoked by alias); 25 Nov 2008 17:59:31 -0000 Received: (qmail 2055 invoked by uid 22791); 25 Nov 2008 17:59:30 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Nov 2008 17:58:54 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAPHwQUV020041; Tue, 25 Nov 2008 12:58:26 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAPHwOCD030881; Tue, 25 Nov 2008 12:58:24 -0500 Received: from opsy.redhat.com (vpn-13-14.rdu.redhat.com [10.11.13.14]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mAPHwNUM003490; Tue, 25 Nov 2008 12:58:23 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id A4AC6482B4; Tue, 25 Nov 2008 10:58:22 -0700 (MST) To: Joel Brobecker Cc: Jie Zhang , gdb-patches@sourceware.org Subject: Re: PING: [PATCH] Fix a bug of addrmap References: <48FD5DE1.9090105@analog.com> <490E9540.7000207@analog.com> <20081125174613.GF3946@adacore.com> From: Tom Tromey Reply-To: Tom Tromey Date: Wed, 26 Nov 2008 13:53:00 -0000 In-Reply-To: <20081125174613.GF3946@adacore.com> (Joel Brobecker's message of "Tue\, 25 Nov 2008 09\:46\:13 -0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00699.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> Did you familiarize yourself with the code that you'd say that Joel> the patch sounds good to you? If this is the case, I'm quite Joel> happy to trust your judgement. Not really, I'm afraid. I just wanted to make sure I understood the bug report. I still don't understand why the fix is to modify force_transition and not addrmap_mutable_set_empty. Joel> The one comment that I have about this is that it's not automatically Joel> run when we run the testsuite. It would be really nice if they were. Joel> It's not the first time that we have unit-testing like this. Joel> For instance, check we have unit tests for observers, or xfullpath. Joel> Traditionally, they have been implemented inside testsuite/gdb.gdb. Joel> The current solution is not very elegant, in my opinion, as what we Joel> did was debugging GDB and call some functions inside GDB. Ugh. I definitely don't want to do that. FWIW, in this case I was just following test-cp-name-parser. Joel> How about, we add a testcase that "debugs" test-addrmap by simply Joel> running it to completion and checking its output (including the Joel> fact that it exited normally (meaning error code returned is zero)? I will look into it. Tom