From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18266 invoked by alias); 2 Feb 2009 18:42:11 -0000 Received: (qmail 18253 invoked by uid 22791); 2 Feb 2009 18:42:11 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Feb 2009 18:42:05 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n12Ig0lD000812; Mon, 2 Feb 2009 13:42:00 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n12Ig0xf024778; Mon, 2 Feb 2009 13:42:00 -0500 Received: from opsy.redhat.com (vpn-12-182.rdu.redhat.com [10.11.12.182]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n12IfxcB019154; Mon, 2 Feb 2009 13:41:59 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id EE81350826F; Mon, 2 Feb 2009 11:41:57 -0700 (MST) To: Thiago Jung Bauermann Cc: Daniel Jacobowitz , gdb-patches ml Subject: Re: [RFA] Add la_getstr member to language_defn References: <1227417278.28256.183.camel@localhost.localdomain> <20081123161013.GA15069@caradoc.them.org> <1227490821.8533.25.camel@hotblack.bauerhaus> <20081124022858.GA19331@caradoc.them.org> <1227551659.28256.225.camel@localhost.localdomain> <20081124202146.GA1991@caradoc.them.org> <1227564549.28256.248.camel@localhost.localdomain> <1230949603.8380.143.camel@localhost.localdomain> From: Tom Tromey Reply-To: tromey@redhat.com Date: Mon, 02 Feb 2009 18:42:00 -0000 In-Reply-To: <1230949603.8380.143.camel@localhost.localdomain> (Thiago Jung Bauermann's message of "Sat\, 03 Jan 2009 00\:26\:43 -0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00033.txt.bz2 >>>>> "Thiago" == Thiago Jung Bauermann writes: [ la_getstr ] Thiago> The patch doesn't apply anymore. This is the same patch, refreshed Thiago> against HEAD as of Dec 28th. Thiago> + Return 0 on success, errno on failure. */ Thiago> + Thiago> +static int Thiago> +c_get_string (struct value *value, gdb_byte **buffer, int *length, Thiago> + const char **charset) The return value here is a bit funny. For some errors this function calls error, but for others it returns the result of read_string. When would we want the latter behavior? I think perhaps la_getstr should simply have 'void' type and then call error if read_string returns an error. What do you think? Otherwise, this patch seems good to me. I'm not completely comfortable approving it outright; but if there are no objections after a week or so, I will. Tom