From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25574 invoked by alias); 11 Mar 2009 22:25:00 -0000 Received: (qmail 25566 invoked by uid 22791); 11 Mar 2009 22:24:59 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Mar 2009 22:24:46 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2BMOd7A008743; Wed, 11 Mar 2009 18:24:39 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2BMOdMe017335; Wed, 11 Mar 2009 18:24:39 -0400 Received: from opsy.redhat.com (vpn-12-67.rdu.redhat.com [10.11.12.67]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2BMOcXM006697; Wed, 11 Mar 2009 18:24:38 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id BFF8B888546; Wed, 11 Mar 2009 16:24:36 -0600 (MDT) To: Thiago Jung Bauermann Cc: Andre Oliveira Loureiro do Baixo , gdb-patches@sourceware.org Subject: Re: [PATCH] PR exp/9103 References: <20090311153711.GA5197@caradoc.them.org> <1236803010.11106.50.camel@localhost.localdomain> From: Tom Tromey Reply-To: Tom Tromey Date: Thu, 12 Mar 2009 01:11:00 -0000 In-Reply-To: (Tom Tromey's message of "Wed\, 11 Mar 2009 15\:48\:27 -0600") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00163.txt.bz2 Tom> The difficulty is really in deciding the way forward. I don't know Tom> what to do. Just to be clear, here are the issues that I know of. * The patch assumes that iconv recognizes "wchar_t" as a charset name. I have read that this is not universally true, but I have not tested this. I'd be interested in reports on this from folks on non-Linux hosts. * What to do about hosts without an iconv implementation. There are three choices: 1. Require libiconv on such hosts 2. Like #1, but provide a simple way to drop libiconv into the src tree. 3. Write a phony iconv-alike that only handles host charset == target charset, probably also providing "gdb_wchar_t" and various other macros and whatnot to make it all work. Related to this is the question of what to do if we run into a host that has a notably bad iconv. These are roughly in the order in which I'd prefer to do them... but then, the problem does not actually affect any machine I have access to. * I'd like comments on this patch (scroll to the end): http://sourceware.org/ml/gdb-patches/2009-01/msg00363.html It helps with the C case, and IMO at least creates types more along the lines of what I would expect. But, I'm not an expert here and I also don't know whether a similar patch is needed for the stabs reader. Tom