Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <muller@ics.u-strasbg.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix bug in add_alias_cmd
Date: Mon, 08 Jun 2009 15:37:00 -0000	[thread overview]
Message-ID: <m3d49erb2p.fsf@fleche.redhat.com> (raw)
In-Reply-To: <006001c9e6be$6fad8fb0$4f08af10$@u-strasbg.fr> (Pierre Muller's message of "Sat\, 6 Jun 2009 17\:49\:53 +0200")

>>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:

Pierre>   This is due to "bu" being an alias command of "ubreak"
Pierre> for xdb options, but "ubreak" doesn't seem to exist anywhere
Pierre> and I found no trace of it anywhere is the sources :(

Pierre> I fact after looking at the sources, it appears to me
Pierre> that the assertion itself is wrong.
Pierre> prehookee should also be NULL, as the other pointers tested.

Pierre> This small patch fixes it.

Pierre> OK to commit?

Yes, thanks.
IMO, you could have put this patch in under the "obvious" rule.

Pierre> PS: What should we do about 
Pierre> Could I also remove that line 
Pierre>  if (xdb_commands)
Pierre>     {
Pierre>       add_com_alias ("ba", "break", class_breakpoint, 1);
Pierre>       add_com_alias ("bu", "ubreak", class_breakpoint, 1);
Pierre>     }

You can just delete the "bu" line.

If you want you could do some archaeology to see whether ubreak ever
existed and, if so, when and why it was removed.

Tom


  reply	other threads:[~2009-06-08 15:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-06 15:50 Pierre Muller
2009-06-08 15:37 ` Tom Tromey [this message]
2009-06-08 16:06   ` Pierre Muller
2009-06-08 22:42     ` Tom Tromey
2009-06-08 16:26 ` Daniel Jacobowitz
2009-06-08 16:59   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3d49erb2p.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox