From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64359-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16489 invoked by alias); 9 Jun 2009 21:15:27 -0000
Received: (qmail 16476 invoked by uid 22791); 9 Jun 2009 21:15:25 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Jun 2009 21:15:18 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n59LF96j010137; 	Tue, 9 Jun 2009 17:15:09 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n59LF7LU026472; 	Tue, 9 Jun 2009 17:15:08 -0400
Received: from opsy.redhat.com (vpn-12-99.rdu.redhat.com [10.11.12.99]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n59LF6no017598; 	Tue, 9 Jun 2009 17:15:07 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 6A0B8486A3; Tue,  9 Jun 2009 15:15:05 -0600 (MDT)
To: "Pierre Muller" <muller@ics.u-strasbg.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA] breakpoint.c ARI fixes
References: <000301c9e8cb$e8592050$b90b60f0$@u-strasbg.fr>
From: Tom Tromey <tromey@redhat.com>
Reply-To: tromey@redhat.com
Date: Tue, 09 Jun 2009 21:15:00 -0000
In-Reply-To: <000301c9e8cb$e8592050$b90b60f0$@u-strasbg.fr> (Pierre Muller's message of "Tue\, 9 Jun 2009 08\:31\:21 +0200")
Message-ID: <m3d49dhzxi.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-06/txt/msg00246.txt.bz2

>>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:

Pierre>   The reason why I didn't check them in as obvious
Pierre> is only that for some of the if assignment rules,
Pierre> the assignment appear as a second test, meaning
Pierre> that it is not always executed in old code, while it is 
Pierre> in new code in print_one_breakpoint_location.

[...]

Pierre>    Is this OK?

Yes.  Thanks for working on this.

Pierre> I would like to know if the minimal ChangeLog
Pierre> below is enough or if I should use the long version
Pierre> listing all modified functions.

You must list them all, I'm afraid.

Pierre> +      if ((bsp->breakpoint_at != NULL)
Pierre> +	  && (bsp->breakpoint_at->owner->type == bp_step_resume)
Pierre> +	  && (bsp->breakpoint_at->owner->thread == current_thread
Pierre> +	      || bsp->breakpoint_at->owner->thread == -1))

Pierre> +  if ((ex_event != EX_EVENT_THROW)
Pierre> +      && (ex_event != EX_EVENT_CATCH))

As long as you are fixing some formatting stuff, you might as well
remove the extra parens from these expressions.

Tom