From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: next/finish/etc -vs- exceptions
Date: Fri, 24 Jul 2009 19:18:00 -0000 [thread overview]
Message-ID: <m3d47qrnjo.fsf@fleche.redhat.com> (raw)
In-Reply-To: <200907241825.41764.pedro@codesourcery.com> (Pedro Alves's message of "Fri\, 24 Jul 2009 18\:25\:41 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
Pedro> As it is in your patch, you're reusing the longjmp paths in
Pedro> infrun.c and co., but it may end up that's not a good choice.
Yeah, I wondered about that. I did it this way because the user
functionality is really similar; but if the implementation needs diverge
then it is not a good approach.
Pedro> I also thought at the time that there were some things in that
Pedro> patch (I didn't look at this new one yet), that should be split
Pedro> into independent changes, like changes to insert longjmp breakpoints
Pedro> in a few commands that didn't had them inserted (but memory is a
Pedro> bit vague by now though, I can't remember exact details).
Yes, that would make sense. I can do that. (And, your recollection is
correct here.)
Pedro> I did brush
Pedro> up my only-follow-longjmp-if-going-outer patches a bit and I was
Pedro> aiming at posting it before you had updated your patch, but obviously
Pedro> I failed. :-/
No problem!
Pedro> I think if we have a chance of looking at what needs addressing
Pedro> for longjmp first (and split your changes that concern with longjmp
Pedro> too), we will have a better result. Would you mind that?
Not at all. I'll wait to see that and then see what changes and/or
splits my patch needs.
Tom
next prev parent reply other threads:[~2009-07-24 17:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 22:32 Tom Tromey
2009-05-30 21:08 ` Doug Evans
2009-05-30 23:18 ` Tom Tromey
2009-06-10 16:13 ` Joel Brobecker
2009-06-10 16:50 ` Tom Tromey
2009-06-10 17:05 ` Pedro Alves
2009-06-10 17:13 ` Daniel Jacobowitz
2009-06-10 17:47 ` Pedro Alves
2009-06-10 18:32 ` Tom Tromey
2009-06-10 18:49 ` Pedro Alves
2009-06-12 20:49 ` Tom Tromey
2009-06-12 21:51 ` Pedro Alves
2009-06-12 22:07 ` Pedro Alves
2010-11-25 4:54 ` Jan Kratochvil
2009-06-11 14:45 ` Joel Brobecker
2009-06-11 15:47 ` Tom Tromey
2009-07-24 17:38 ` Tom Tromey
2009-07-24 18:54 ` Pedro Alves
2009-07-24 19:18 ` Tom Tromey [this message]
2009-09-09 18:56 ` Tom Tromey
2010-10-07 1:37 Tom Tromey
2010-11-24 17:53 ` Joel Brobecker
2010-11-24 18:24 ` Tom Tromey
2010-11-25 7:59 ` Jan Kratochvil
2010-11-27 17:25 ` Doug Evans
2010-11-28 8:29 ` Joel Brobecker
2010-11-30 16:43 ` Tom Tromey
2010-11-30 17:02 ` Jan Kratochvil
2010-11-30 17:15 ` Phil Muldoon
2010-11-30 20:15 ` Tom Tromey
2010-12-01 13:42 ` Jan Kratochvil
2010-12-01 21:40 ` Tom Tromey
2010-11-30 18:23 ` Tom Tromey
2010-11-30 18:55 ` Tom Tromey
2010-12-02 15:32 ` Tom Tromey
2010-12-09 16:37 ` Tom Tromey
2010-12-10 4:52 ` Jan Kratochvil
2010-12-10 20:07 ` Tom Tromey
2010-12-11 5:27 ` Jan Kratochvil
2010-12-15 21:18 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d47qrnjo.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox