From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 418 invoked by alias); 19 Jan 2010 02:44:37 -0000 Received: (qmail 407 invoked by uid 22791); 19 Jan 2010 02:44:36 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Jan 2010 02:44:32 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0J2iUnd012986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 18 Jan 2010 21:44:30 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0J2iUi6032337; Mon, 18 Jan 2010 21:44:30 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o0J2iTNI018926; Mon, 18 Jan 2010 21:44:29 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id B6EAC3782A6; Mon, 18 Jan 2010 19:44:28 -0700 (MST) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Fix misplaced line numbers References: <20100118220139.GA13151@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Tue, 19 Jan 2010 02:44:00 -0000 In-Reply-To: <20100118220139.GA13151@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Mon, 18 Jan 2010 23:01:39 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00463.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> 2010-01-18 Jan Kratochvil Jan> * gdb.mi/mi-break.exp (set line_callme_head, set line_callme_body): New. Jan> (test_ignore_count): Declare line_callme_body global. Jan> (run to breakpoint with ignore count): Use line_callme_body. Jan> * gdb.mi/mi-cli.exp (set line_main_head, set line_main_body) Jan> (set line_main_hello, set line_main_return): Reindent. Jan> (set line_callee4_head, set line_callee4_body, set line_callee4_next): Jan> New. Jan> (continue to callee4): Use line_callee4_body. Jan> (check *stopped from CLI command): Use line_callee4_next. Jan> * gdb.mi/mi2-cli.exp (set line_main_head, set line_main_body) Jan> (set line_main_hello, set line_main_return): Reindent. Jan> (set line_callee4_head, set line_callee4_body): New. Jan> (continue to callee4): Use line_callee4_body. I didn't look, so if you didn't already commit this, it is OK. I think this would qualify as obvious. Thanks for finding & fixing this. Tom