From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Code cleanup: objfile->name is never NULL
Date: Wed, 22 Sep 2010 20:40:00 -0000 [thread overview]
Message-ID: <m3d3s57efe.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100922094323.GA20792@host1.dyn.jankratochvil.net> (Jan Kratochvil's message of "Wed, 22 Sep 2010 11:43:23 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> there is some FUD in GDB code whether objfile->name can be NULL. I
Jan> haven't found a way it could be. Also a lot of GDB code already
Jan> assumes it is not NULL.
I agree with this patch.
Jan> - if (!objfile->name)
Jan> - return;
Jan> load_auto_scripts_for_objfile (objfile);
This part made me realize that we should probably have some kind of "is
a file" flag on the objfile, to avoid trying to load files relative to a
phony name like "<<anonymous objfile>>".
Tom
next prev parent reply other threads:[~2010-09-22 19:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 17:01 Jan Kratochvil
2010-09-22 20:40 ` Tom Tromey [this message]
2010-09-22 22:52 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3s57efe.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox