From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28430 invoked by alias); 14 Oct 2010 17:48:44 -0000 Received: (qmail 28367 invoked by uid 22791); 14 Oct 2010 17:48:42 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Oct 2010 17:48:29 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9EHmM3J005877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 14 Oct 2010 13:48:23 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o9EHmMAq026212; Thu, 14 Oct 2010 13:48:22 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o9EHmLHw012155; Thu, 14 Oct 2010 13:48:21 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id CB5DF3791BC; Thu, 14 Oct 2010 11:48:20 -0600 (MDT) From: Tom Tromey To: "Pierre Muller" Cc: Subject: Re: [PATCH] Avoid pascal crashes for structures having fields without names References: <35800.5107882947$1287069713@news.gmane.org> Date: Thu, 14 Oct 2010 17:48:00 -0000 In-Reply-To: <35800.5107882947$1287069713@news.gmane.org> (Pierre Muller's message of "Thu, 14 Oct 2010 17:21:39 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00246.txt.bz2 >>>>> "Pierre" == Pierre Muller writes: Pierre> + && TYPE_FIELDS (type) [0].name I think it is more idiomatic to use the accessors like TYPE_FIELD_NAME. Tom