From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3629 invoked by alias); 2 Feb 2011 21:35:59 -0000 Received: (qmail 3348 invoked by uid 22791); 2 Feb 2011 21:35:57 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Feb 2011 21:35:51 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p12LZmiD020640 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 2 Feb 2011 16:35:49 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p12LZmAX003513; Wed, 2 Feb 2011 16:35:48 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p12LZleS020111; Wed, 2 Feb 2011 16:35:48 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 89ACC3783AD; Wed, 2 Feb 2011 14:35:47 -0700 (MST) From: Tom Tromey To: sami wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch] Support inferior events in python References: <4D2342A2.7060102@redhat.com> <4D34AF3F.4090006@redhat.com> <4D39FFFD.80304@redhat.com> <4D49C69A.20401@redhat.com> Date: Wed, 02 Feb 2011 21:35:00 -0000 In-Reply-To: <4D49C69A.20401@redhat.com> (sami wagiaalla's message of "Wed, 02 Feb 2011 16:03:22 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00032.txt.bz2 >>>>> "Sami" == sami wagiaalla writes: Sami> Hmm... We can just create the corresponding Python object, but Sami> shouldn't this situation be an error condition since Sami> gdbpy_breakpoint_created is observing breakpoint creation and creating Sami> the needed python objects ? No, because gdbpy_breakpoint_created filters out some breakpoints, notably internal ones. Sami> Yes that is correct. I created a new event type called ThreadEvent Sami> to be a parent to all events which can be thread specific. Stop Sami> events and continue event are now children of thread event. In this case I think ThreadEvent should be in the docs. Sami> +PyObject * Sami> +create_breakpoint_event_object (struct bpstats *bs) Sami> +{ Sami> + PyObject *breakpoint = gdbpy_breakpoint_from_bpstats (bs); Sami> + PyObject *breakpoint_event_obj = Sami> + create_stop_event_object (&breakpoint_event_object_type); Sami> + if (!breakpoint_event_obj || !breakpoint) Sami> + goto fail; This wouldn't work, since if breakpoint==NULL, we never set an error message. I think this code should probably have a way to cause emit_stop_event to fall through to the "unknown" case. I didn't see py-threadevent.c in the patch. Tom