From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79738-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21006 invoked by alias); 16 Mar 2011 15:25:36 -0000
Received: (qmail 20994 invoked by uid 22791); 16 Mar 2011 15:25:34 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Mar 2011 15:25:29 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2GFOuvj031876	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 16 Mar 2011 11:24:56 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2GFOuTS009941;	Wed, 16 Mar 2011 11:24:56 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2GFOsJq026446;	Wed, 16 Mar 2011 11:24:55 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 72EC2378CA4; Wed, 16 Mar 2011 09:24:54 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: "Andrew Burgess" <aburgess@broadcom.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Clear GREP_OPTIONS environment variable.
References: <4D807468.8020703@broadcom.com>
Date: Wed, 16 Mar 2011 15:43:00 -0000
In-Reply-To: <4D807468.8020703@broadcom.com> (Andrew Burgess's message of	"Wed, 16 Mar 2011 08:27:20 +0000")
Message-ID: <m3d3lr5bqy.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00851.txt.bz2

>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:

Andrew> The test gdb.base/maint.exp shells out from gdb to use grep. I
Andrew> have GREP_OPTIONS="--color=auto" in my environment and this
Andrew> causes the test to fail. The patch below clears this environment
Andrew> variable before running gdb. Ok to apply?

Andrew> 2011-03-15  Andrew Burgess  <aburgess@broadcom.com>
Andrew> 	* lib/gdb.exp (default_gdb_start): Clear the GREP_OPTIONS
Andrew> 	environment variable to make grep output more predictable.

Ok.

Tom