From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25671 invoked by alias); 28 Jul 2011 15:18:20 -0000 Received: (qmail 25646 invoked by uid 22791); 28 Jul 2011 15:18:18 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jul 2011 15:18:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6SFHR6G022481 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Jul 2011 11:17:27 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6SFHQ9S000755; Thu, 28 Jul 2011 11:17:27 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6SFHOuH007577; Thu, 28 Jul 2011 11:17:24 -0400 From: Tom Tromey To: iam ahal Cc: gdb-patches@sourceware.org, eliz@gnu.org, pmuldoon@redhat.com, brobecker@adacore.com, pedro@codesourcery.com, drow@false.org Subject: Re: [patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename) References: <20110627160029.GF20676@adacore.com> <834o33qlm9.fsf@gnu.org> <83bowq6x7f.fsf@gnu.org> Date: Thu, 28 Jul 2011 15:34:00 -0000 In-Reply-To: (iam ahal's message of "Mon, 25 Jul 2011 00:25:44 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00787.txt.bz2 >>>>> "iam" == iam ahal writes: iam> I've created new patch where I've added new option called iam> skip-compile-dir. Patch in attachment. I didn't make ChangeLog yet. iam> If you like this implementation I prepare ChangeLog and testsuite script. iam> I can change something if you want. Thanks. I forget (I never keep records of this, I think perhaps I should) -- did we get you started on the copyright assignment paperwork? iam> +static int backtrace_skip_compile; iam> +static void Newline between these two lines. iam> +char * iam> +get_display_filename_from_sal (struct symtab_and_line *sal) Should have an introductory comment before this function. It should return a 'const char *'. iam> + if (backtrace_skip_compile && filename && dirname iam> + && strstr(filename, dirname)) Space before the open paren. But this seems like a strange test to me, strstr can't really be correct. iam> + { iam> + /* +1 means skip directory separator */ iam> + return filename + strlen(dirname) + 1; Comments should end with a period and two spaces, per GNU standards. Can there never be multiple separators? It seems like there could be, in which case you want a loop. iam> + add_setshow_boolean_cmd ("skip-compile-dir", class_obscure, I'm not especially fond of this name. I don't have a better suggestion though. iam> + const char *display_filename = get_display_filename_from_sal(&sal); Space before open paren. iam> + if (display_filename == NULL) iam> + display_filename = sal.symtab->filename; It seems that perhaps get_display_filename_from_sal should do this. iam> - ui_out_field_string (uiout, "file", sal.symtab->filename); iam> + ui_out_field_string (uiout, "file", display_filename); I'm surprised this change has any effect. I thought the compilation directory and the source file name were kept separate in the symtab. What is actually happening? Tom