From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8807 invoked by alias); 26 Aug 2011 17:38:01 -0000 Received: (qmail 8797 invoked by uid 22791); 26 Aug 2011 17:38:00 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Aug 2011 17:37:42 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7QHbXL8026722 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Aug 2011 13:37:33 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7QHbWqE018362; Fri, 26 Aug 2011 13:37:32 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7QHbVJU011635; Fri, 26 Aug 2011 13:37:31 -0400 From: Tom Tromey To: Pedro Alves Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch 2/2] Do not bpstat_clear_actions on throw_exception #3 References: <20110822145150.GB11817@host1.jankratochvil.net> <201108241119.03993.pedro@codesourcery.com> <20110826101359.GA27121@host1.jankratochvil.net> <201108261245.32822.pedro@codesourcery.com> Date: Fri, 26 Aug 2011 17:38:00 -0000 In-Reply-To: <201108261245.32822.pedro@codesourcery.com> (Pedro Alves's message of "Fri, 26 Aug 2011 12:45:32 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00498.txt.bz2 Pedro> I think the neatest fix would be to add some try/catch/finaly Pedro> syntax to the cli. There was a patch for that posted eons ago: Pedro> http://sourceware.org/ml/gdb-patches/2001-12/msg00449.html This is also languishing in bugzilla. I think it would be a decent addition. While I tend to think that more serious scripting should be done in Python now, I think there is also room for CLI stuff. (I don't have a hard-and-fast rule here; I don't want to try to expand the CLI into a full-blown language, but I don't mind additions much either.) This won't address Jan's use case, but you dug up another patch that does, so all is well :) FWIW I wrote a simple "ignore-errors" command in Python to satisfy my own occasional need for this. Jan> (a) throw_exception will call bpstat_clear_actions only if Jan> exception.error is not NOT_AVAILABLE_ERROR (adding later my new Jan> ENTRY_VALUE_NOT_AVAILABLE). Pedro> I don't like this at all. Me neither. This code has really got to go. Tom