From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18532 invoked by alias); 30 Aug 2011 20:28:36 -0000 Received: (qmail 18522 invoked by uid 22791); 30 Aug 2011 20:28:35 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 20:28:21 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7UKSKaU026853 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Aug 2011 16:28:21 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7UKSJGV015883; Tue, 30 Aug 2011 16:28:19 -0400 From: Phil Muldoon To: Tom Tromey Cc: matt rice , gdb-patches@sourceware.org Subject: Re: [PATCH 4/7] [python] API for macros: Add methods to get a gdb.Macro. References: <1314198654-9008-1-git-send-email-ratmice@gmail.com> <1314198654-9008-5-git-send-email-ratmice@gmail.com> Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Tue, 30 Aug 2011 20:28:00 -0000 In-Reply-To: (Tom Tromey's message of "Tue, 30 Aug 2011 11:41:09 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00634.txt.bz2 Tom Tromey writes: >>>>>> "Phil" == Phil Muldoon writes: > > Phil> I think this should return a Tuple. Tuples are immutable, and unless > Phil> you for see a use for the user to manipulate the List, we should guard > Phil> against it. If you agree, please alter stpy_macros too. > > Using a tuple means you have to iterate twice -- once to count the > objects and once to make the tuple. You can use a list, and then convert it to a tuple: PyList_AsTuple We already use the above. If you wanted to, you could use PyTuple_Ruse, as long as there is one reference to the tuple. But building as a list, and returning as a tuple seems reasonable to me. Cheers Phil