From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16590 invoked by alias); 5 Oct 2011 14:01:04 -0000 Received: (qmail 16580 invoked by uid 22791); 5 Oct 2011 14:01:03 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Oct 2011 14:00:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p95E0i8C015262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 5 Oct 2011 10:00:45 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p95E0iFh019808; Wed, 5 Oct 2011 10:00:44 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p95E0hdp032682; Wed, 5 Oct 2011 10:00:43 -0400 From: Tom Tromey To: Abhijit Halder Cc: "gdb-patches\@sourceware.org ml" Subject: Re: [PATCH] PR-10034 Bad space handling in `set remote exec-file' command. References: Date: Wed, 05 Oct 2011 14:01:00 -0000 In-Reply-To: (Abhijit Halder's message of "Wed, 5 Oct 2011 09:48:45 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00135.txt.bz2 >>>>> "Abhijit" == Abhijit Halder writes: Tom> Why are you changing this case? Abhijit> The idea was that the same code block is common between two adjacent Abhijit> cases and hence can be combined together. I see. It isn't clear to me that 'string' types should be treated the same as filenames in this way. I guess I would be inclined not to change it, but I don't feel very strongly about it. Tom