From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44818 invoked by alias); 13 Feb 2017 17:18:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44802 invoked by uid 89); 13 Feb 2017 17:18:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.3 required=5.0 tests=AWL,BAYES_50,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*i:sk:1486989, UD:py-record-btrace.c, sk:py-reco, sk:pyreco X-HELO: mail-oi0-f67.google.com Received: from mail-oi0-f67.google.com (HELO mail-oi0-f67.google.com) (209.85.218.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Feb 2017 17:18:19 +0000 Received: by mail-oi0-f67.google.com with SMTP id j15so54207oih.0 for ; Mon, 13 Feb 2017 09:18:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=c4NY8A3o1iDjMnIqNAzE35jBuQ4ObbBI491e4PayCgs=; b=DwiTeIzjzGSnfJeCGWvcOykZ7eCjv4ygfnD+myx4TlII0rfCXYRfYocfeuNpWH4Pf4 w0WovoBm4PBGQp+5a1THIKMU6oXbqeg7TV9oe243+pjkAUH0BxnWt21DSZnh0sj7+kbz 8KNdxWajV1KlI0ZXI3tkPfIeVTAh7nqfEMK01iZDaQ1S6YRf4tElUlI7tjEFylPnx6+Z Yexx0SbgXJiREthlPPUvIMEq7eS5PcSkGjmTUB27OnA4O3PHFK7K3HIUrm0zXDsQ/48v X2igBEjdyV5eEwuZ9smOk6uIxEl5DpoDuJ2+OPhCoHX7r+GSbMvoZmdYGTmbkDF99bMJ 5q0Q== X-Gm-Message-State: AMke39lchsdlJWLrgSIS3LcygNMvvOYAyiyY9UDzSuCU5fYi4NjNhZeknAMDK86hIuna2w== X-Received: by 10.84.143.131 with SMTP id 3mr30881049plz.56.1487006297697; Mon, 13 Feb 2017 09:18:17 -0800 (PST) Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53]) by smtp.gmail.com with ESMTPSA id z127sm22251014pgz.29.2017.02.13.09.18.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Feb 2017 09:18:17 -0800 (PST) From: Doug Evans To: Tim Wiederhake Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com, palves@redhat.com Subject: Re: [PATCH v6 0/9] Python bindings for btrace recordings References: <1486989450-11313-1-git-send-email-tim.wiederhake@intel.com> Date: Mon, 13 Feb 2017 17:18:00 -0000 In-Reply-To: <1486989450-11313-1-git-send-email-tim.wiederhake@intel.com> (Tim Wiederhake's message of "Mon, 13 Feb 2017 13:37:21 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00351.txt.bz2 Tim Wiederhake writes: > Hello everyone! > > This patch series adds Python bindings for btrace recordings. > > V1 of this series can be found here: > https://sourceware.org/ml/gdb-patches/2016-10/msg00733.html > > V2 of this series can be found here: > https://sourceware.org/ml/gdb-patches/2016-11/msg00084.html > > V3 of this series can be found here: > https://sourceware.org/ml/gdb-patches/2016-11/msg00605.html > > V4 of this series can be found here: > https://sourceware.org/ml/gdb-patches/2017-01/msg00044.html > > V5 of this series can be found here: > https://sourceware.org/ml/gdb-patches/2017-01/msg00616.html > > Changes from V5: > - Skip gdb.python/py-record-full.exp if recording is not supported. > - s/symbol/SAL/ in comment in py-record-btrace.c. > - Replaced mem_fileopen by string_file in py-record-btrace.c. > - Simplified btpy_list_count and added comment in py-record-btrace.c. > - Removed unused variable in recpy_bt_goto (leftover from previous refactoring) > in py-record-btrace.c. > - Moved opening curly braces to new line in py-record-btrace.c. > > The documentation parts are already approved by Eli. > > Is this good to go? LGTM