From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1692 invoked by alias); 18 Apr 2009 17:12:46 -0000 Received: (qmail 1684 invoked by uid 22791); 18 Apr 2009 17:12:46 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 18 Apr 2009 17:12:39 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3IHCZJA014233; Sat, 18 Apr 2009 13:12:35 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3IHCYct004059; Sat, 18 Apr 2009 13:12:34 -0400 Received: from opsy.redhat.com (vpn-12-21.rdu.redhat.com [10.11.12.21]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3IHCXx1022907; Sat, 18 Apr 2009 13:12:34 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 9F41F3784C3; Sat, 18 Apr 2009 11:12:32 -0600 (MDT) To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: FYI: fix Solaris problem with auto host charset References: <83y6tyihzh.fsf@gnu.org> From: Tom Tromey Reply-To: Tom Tromey Date: Sat, 18 Apr 2009 17:12:00 -0000 In-Reply-To: <83y6tyihzh.fsf@gnu.org> (Eli Zaretskii's message of "Sat\, 18 Apr 2009 09\:38\:42 +0300") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00487.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Eli> Btw, why is the code assuming that nl_langinfo always returns a Eli> meaningful result? Oversight. Eli> Also, I don't quite get the reason why nl_langinfo is not called in Eli> the PHONY_ICONV case. It seems we blindly assume the native charset Eli> is Latin-1 in that case, but perhaps nl_langinfo, if it exists, will Eli> give a better guess? In the PHONY_ICONV case we have no way to convert between character sets. I think this only affects u'' and U''; so it really a matter of which failure you want in this situation. If you want to change this, it is fine by me. Tom