From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-63182-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 593 invoked by alias); 21 Apr 2009 23:44:42 -0000
Received: (qmail 585 invoked by uid 22791); 21 Apr 2009 23:44:41 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Apr 2009 23:44:33 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3LNhjYl011578; 	Tue, 21 Apr 2009 19:43:46 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3LNhi4M015167; 	Tue, 21 Apr 2009 19:43:44 -0400
Received: from opsy.redhat.com (vpn-14-116.rdu.redhat.com [10.11.14.116]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3LNhhQO030041; 	Tue, 21 Apr 2009 19:43:43 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id CFC7E37829A; Tue, 21 Apr 2009 17:43:42 -0600 (MDT)
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] prefer in-tree libiconv over the system libiconv
References: <20090420183619.GB5858@adacore.com> 	<m3fxg32fk6.fsf@fleche.redhat.com> <20090420213559.GS2904@adacore.com> 	<20090421210032.GF23807@adacore.com>
From: Tom Tromey <tromey@redhat.com>
Reply-To: tromey@redhat.com
Date: Tue, 21 Apr 2009 23:44:00 -0000
In-Reply-To: <20090421210032.GF23807@adacore.com> (Joel Brobecker's message of "Tue\, 21 Apr 2009 14\:00\:32 -0700")
Message-ID: <m3bpqpzi6p.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-04/txt/msg00576.txt.bz2

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> The diff seems awful, but all I did was move the block for ../libiconv
Joel> up before we check for iconv in the libc. And I made us check iconv
Joel> in libc only if we haven't found iconv in ../libiconv.

The code change looks fine FWIW.

Tom