Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] cleanup of syscall consts in process record
Date: Tue, 08 Sep 2009 19:11:00 -0000	[thread overview]
Message-ID: <m3bpllw8tm.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4AA6AB33.20304@vmware.com> (Michael Snyder's message of "Tue, 08 	Sep 2009 12:06:27 -0700")

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> Nah, the idea was to get rid of magic numbers,
Michael> plus it makes the code more readable.  Self-documenting.

Thanks for doing this, I think it helps readability a lot.

After Sergio's patch perhaps we could generate the enums from the XML
files.

Tom


  reply	other threads:[~2009-09-08 19:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-05 21:35 Michael Snyder
2009-09-06  1:56 ` Hui Zhu
2009-09-06  2:49   ` Joel Brobecker
2009-09-06  4:27     ` Hui Zhu
2009-09-08 16:49 ` Joel Brobecker
2009-09-08 17:42   ` Michael Snyder
2009-09-08 17:48     ` Michael Snyder
2009-09-08 18:04       ` Joel Brobecker
2009-09-08 19:08         ` Michael Snyder
2009-09-08 19:11           ` Tom Tromey [this message]
2009-09-08 19:31           ` Mark Kettenis
2009-09-08 20:08           ` Joel Brobecker
2009-09-08 22:51             ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3bpllw8tm.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox