From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16793 invoked by alias); 30 Sep 2009 16:47:28 -0000 Received: (qmail 16783 invoked by uid 22791); 30 Sep 2009 16:47:27 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Sep 2009 16:47:23 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8UGkoD6027867; Wed, 30 Sep 2009 12:46:50 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8UGknmP021144; Wed, 30 Sep 2009 12:46:50 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n8UGkmUM006927; Wed, 30 Sep 2009 12:46:48 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id E88993782D4; Wed, 30 Sep 2009 10:46:47 -0600 (MDT) From: Tom Tromey To: Jonas Maebe Cc: Joel Brobecker , Mark Kettenis , gdb-patches@sourceware.org Subject: Re: [patch] Set calling convention of methods References: <7B6EF4DA-76C8-4D9C-8B9F-94153EF1C4E1@elis.ugent.be> <691B0BA8-C606-42FF-A796-76CC9C31556A@elis.ugent.be> <200904222215.n3MMF0p2006994@brahms.sibelius.xs4all.nl> <19C107AA-5271-4C23-A6D2-AFF75BBAC4E4@elis.ugent.be> <5AA3BCA9-1ECF-446E-8B49-3132F0E470FB@elis.ugent.be> <20090930000225.GA10338@adacore.com> <8F3B6095-4766-432D-ABB5-AB4DAA2D5572@elis.ugent.be> Reply-To: Tom Tromey Date: Wed, 30 Sep 2009 16:47:00 -0000 In-Reply-To: <8F3B6095-4766-432D-ABB5-AB4DAA2D5572@elis.ugent.be> (Jonas Maebe's message of "Wed, 30 Sep 2009 13:18:22 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00954.txt.bz2 >>>>> "Jonas" == Jonas Maebe writes: >> diff --git a/include/elf/dwarf2.h b/include/elf/dwarf2.h >>> index a7448dc..efa786e 100644 >>> --- a/include/elf/dwarf2.h >>> +++ b/include/elf/dwarf2.h >>> @@ -662,7 +662,8 @@ enum dwarf_calling_convention >>> DW_CC_normal = 0x1, >>> DW_CC_program = 0x2, >>> DW_CC_nocall = 0x3, >>> - DW_CC_GNU_renesas_sh = 0x40 >>> + DW_CC_GNU_renesas_sh = 0x40, >>> + DW_CC_GNU_borland_fastcall_i386 = 0x41 I am on a mission to ensure that all GNU extensions to DWARF are nicely documented. So, at the very least, this needs a comment explaining the meaning of this flag; maybe mentioning the `fastcall' attribute in GCC (if indeed this is the same thing). Jonas> Later on, Tom clarified that he thought that the gdb and gcc versions Jonas> of dwarf2.h should actually be merged into a single copy, but that I Jonas> shouldn't worry about this since the divergence started before my Jonas> patch: http://sourceware.org/ml/gdb-patches/2009-04/msg00099.html I've merged these now. I think the usual approach for such merged files is that GCC is the master copy. Tom