From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68334-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16415 invoked by alias); 10 Nov 2009 22:26:29 -0000
Received: (qmail 16406 invoked by uid 22791); 10 Nov 2009 22:26:28 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Nov 2009 22:26:24 +0000
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAAMQNn3032135 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <gdb-patches@sourceware.org>; Tue, 10 Nov 2009 17:26:23 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAAMQM3a032524; 	Tue, 10 Nov 2009 17:26:23 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nAAMQLTs017185; 	Tue, 10 Nov 2009 17:26:22 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 9AC2E3782CF; Tue, 10 Nov 2009 15:26:21 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Sami Wagiaalla <swagiaal@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [patch 1/2] Perform a namespace lookup at every block level
References: <4A57512A.7090208@redhat.com> 	<20090710194949.GA2064@caradoc.them.org> <4A5B68A4.30006@redhat.com> 	<4A68B91D.2080206@redhat.com> <4A8B0FBA.4090501@redhat.com> 	<m3my3vjcu9.fsf@fleche.redhat.com> <4ADE21F9.7020801@redhat.com> 	<m3ljie9fzf.fsf@fleche.redhat.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Tue, 10 Nov 2009 22:26:00 -0000
In-Reply-To: <m3ljie9fzf.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue, 	10 Nov 2009 15:23:16 -0700")
Message-ID: <m3bpja9fua.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00241.txt.bz2

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Sami> +         it is applicable.  */
Sami> +      if (strncmp (scope, current->import_dest, strlen (current->import_dest)) == 0)

Tom> From my reading this doesn't exactly match the comment -- can
Tom> current-> import_dest be an extension of scope?  Like, if scope is "x"
Tom> and import_dest is "xyz"?

So, I sent that and then immediately realized I have no idea what I was
thinking, since it doesn't make sense.

This patch is ok with the few minor lexical fixes I pointed out.
Thanks.

Tom