From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7691 invoked by alias); 6 Dec 2010 21:41:09 -0000 Received: (qmail 7680 invoked by uid 22791); 6 Dec 2010 21:41:08 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Dec 2010 21:41:03 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB6LevIe016584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Dec 2010 16:40:57 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oB6Leucj018226; Mon, 6 Dec 2010 16:40:57 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oB6LeuFV028016; Mon, 6 Dec 2010 16:40:56 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id EA74E3780EF; Mon, 6 Dec 2010 14:40:55 -0700 (MST) From: Tom Tromey To: Marc Khouzam Cc: "'gdb-patches\@sourceware.org'" Subject: Re: [MI] Segfault using 'interpreter-exec mi' References: Date: Mon, 06 Dec 2010 21:41:00 -0000 In-Reply-To: (Marc Khouzam's message of "Mon, 6 Dec 2010 16:34:32 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00061.txt.bz2 >>>>> "Marc" == Marc Khouzam writes: Marc> Mostly because the error output of mi_parse() has to use some of Marc> the data that was actually parsed in mi_parse(), which lead me to Marc> have to play around with return values while handling exceptions, Marc> or having to free some memory _after_ calling error(), which I Marc> didn't know how to do. You can install an 'xfree' cleanup before calling error. Marc> Could we have the brute force fix now, and leave the improvement Marc> for later? I will look at it tomorrow. Tom