From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79004-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30739 invoked by alias); 2 Mar 2011 18:30:14 -0000
Received: (qmail 30724 invoked by uid 22791); 2 Mar 2011 18:30:13 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_XT,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 18:30:08 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p22ITxbg031966	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 2 Mar 2011 13:29:59 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p22ITwCo032289;	Wed, 2 Mar 2011 13:29:59 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p22ITvGh003309;	Wed, 2 Mar 2011 13:29:57 -0500
Received: by opsy.redhat.com (Postfix, from userid 500)	id 3C20E37831A; Wed,  2 Mar 2011 11:29:57 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: Ulrich Weigand <uweigand@de.ibm.com>, Yao Qi <yao@codesourcery.com>,        "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Fix magic number in arm-tdep.c
References: <201103021412.p22EC5vZ015623@d06av02.portsmouth.uk.ibm.com>	<4D6E88BC.9080905@vmware.com>
Date: Wed, 02 Mar 2011 18:30:00 -0000
In-Reply-To: <4D6E88BC.9080905@vmware.com> (Michael Snyder's message of "Wed,	02 Mar 2011 10:13:16 -0800")
Message-ID: <m3bp1t2x5m.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00117.txt.bz2

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

>>> -		nextpc = (rn == 15) ? pc_val + 8
>>> +		nextpc = (rn == ARM_PC_REGNUM) ? pc_val + 8
>>> : get_frame_register_unsigned (frame, rn);
>> 
>> (? and : should remain in the same column).
>> 

Michael> I don't agree - : is an operator and should be indented by just
Michael> two spaces.  As emacs does by default.

You're supposed to add extra parens to make it line up.
See the "Formatting" node in the GNU Standards.

Tom