From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14980 invoked by alias); 19 Apr 2011 20:11:34 -0000 Received: (qmail 14939 invoked by uid 22791); 19 Apr 2011 20:11:17 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 20:10:57 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3JKAmTO008789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 19 Apr 2011 16:10:49 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3JKAm69031631; Tue, 19 Apr 2011 16:10:48 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3JKAl2X028971; Tue, 19 Apr 2011 16:10:48 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 991EF37800C; Tue, 19 Apr 2011 14:10:47 -0600 (MDT) From: Tom Tromey To: "Baars\, M.J." Cc: gdb-patches@sourceware.org Subject: Re: print_npx_status_word References: <4DA7166F.10302@gmail.com> <4DA7ED79.3000400@gmail.com> <4DA87235.7060003@gmail.com> <4DA87479.50203@gmail.com> <4DA93270.6030708@gmail.com> <201104160824.p3G8ONWV006175@glazunov.sibelius.xs4all.nl> <4DA99DA1.2090708__5871.13250880993$1302961604$gmane$org@gmail.com> <4DADDBE2.8050704@gmail.com> Date: Tue, 19 Apr 2011 20:11:00 -0000 In-Reply-To: <4DADDBE2.8050704@gmail.com> (M. J. Baars's message of "Tue, 19 Apr 2011 21:00:50 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00342.txt.bz2 Tom> As others have noted, ChangeLog is "prepend only". Tom> We generally don't edit old entries. Michael> As I stated before, it would be unwise though to keep unmaintained Michael> function names in the log entries. You can apply the changes Michael> optionally, but I strongly advise against retaining the original log Michael> entries. The log is just that, a log. Think of it as a primitive version of VC commit messages. It is a document describe a sequence of changes, not a document describing the current state of the source -- the source itself plays that role. Michael> If you don't like the indentation, I suggest you instead modify Michael> you tab-settings locally. Personally I'm used programming with Michael> a little more space than. The usual rule in all projects is "consistent is better than good". GDB fixed the basics of its style many years ago, for better or worse. So, please conform to the prevailing style. Tom> No `//' comments. Michael> I have taken this into account, does that also hold for inline Michael> comments? Yes. GDB is mostly on C89. This is fairly typical in the GNU tools. Tom